chrome/installer/util/copy_reg_key_work_item_unittest.cc - Issue 7946003: C++ Readability for grt.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/copy_reg_key_work_item_unittest.cc

Issue 7946003: C++ Readability for grt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Trimmed down Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <windows.h>	5 #include <windows.h>

6 #include <shlwapi.h> // NOLINT	6 #include <shlwapi.h> // NOLINT

7	7

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "base/win/registry.h"	10 #include "base/win/registry.h"

(...skipping 121 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
132 WorkItem::CreateCopyRegKeyWorkItem(test_data_.root_key(),	132 WorkItem::CreateCopyRegKeyWorkItem(test_data_.root_key(),

133 test_data_.empty_key_path(),	133 test_data_.empty_key_path(),

134 test_data_.non_empty_key_path()));	134 test_data_.non_empty_key_path()));

135 item->set_ignore_failure(true);	135 item->set_ignore_failure(true);

136 EXPECT_TRUE(item->Do());	136 EXPECT_TRUE(item->Do());

137 item->Rollback();	137 item->Rollback();

138 item.reset();	138 item.reset();

139 RegistryTestData::ExpectEmptyKey(test_data_.root_key(),	139 RegistryTestData::ExpectEmptyKey(test_data_.root_key(),

140 test_data_.non_empty_key_path().c_str());	140 test_data_.non_empty_key_path().c_str());

141 }	141 }

	142

OLD	NEW