C++ Readability for grt.

chrome/installer/util/copy_reg_key_work_item.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

[Yash, 2011/10/03 02:17:37]

Please include a brief file comment, describing what you implement here.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#File_Comments

[grt (UTC plus 2), 2011/10/03 15:35:26]

Done.

 #include "chrome/installer/util/copy_reg_key_work_item.h"
 
 #include <shlwapi.h>
 
 #include "base/logging.h"
 #include "base/win/registry.h"
 
 using base::win::RegKey;
 
 CopyRegKeyWorkItem::~CopyRegKeyWorkItem() {
@@ skipping 45 matching lines @@
     } else {
       result = SHCopyKey(predefined_root_, source_key_path_.c_str(),
                          dest_key.Handle(), 0);
       switch (result) {
         case ERROR_FILE_NOT_FOUND:
           // The source didn't exist, so neither should the destination.
           dest_key.Close();
           SHDeleteKey(predefined_root_, dest_key_path_.c_str());
           // Handle like a success.
           result = ERROR_SUCCESS;
           // -- FALL THROUGH TO SUCCESS CASE --

[Yash, 2011/10/03 02:17:37]

No need to have this comment in all caps

[grt (UTC plus 2), 2011/10/03 15:35:26]

Done.

         case ERROR_SUCCESS:
           break;
         default:
           LOG(ERROR) << "Failed to copy key from " << source_key_path_ << " to "
                      << dest_key_path_ << ", result: " << result;
           break;
       }
     }
   }
 
@@ skipping 10 matching lines @@
   if (result != ERROR_SUCCESS && result != ERROR_FILE_NOT_FOUND) {
     LOG(ERROR) << "Failed to delete key at " << dest_key_path_
                << " in rollback, result: " << result;
   }
 
   // Restore the old contents.  The restoration takes on its default security
   // attributes; any custom attributes are lost.
   if (!backup_.WriteTo(predefined_root_, dest_key_path_.c_str()))
     LOG(ERROR) << "Failed to restore key in rollback.";
 }
+