Issue 7946: Remember the clear browsing data combo box selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7946: Remember the clear browsing data combo box selection. (Closed)

Created:
12 years, 2 months ago by developer0420

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remember the clear browsing data combo box selection.

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
M	chrome/browser/browser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/clear_browsing_data.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/clear_browsing_data.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

developer0420

clear browsing data now remembers the combo box selection.

12 years, 2 months ago (2008-10-23 21:56:05 UTC) #1

Finnur

That looks good to me. Only two tiny nits. http://codereview.chromium.org/7946/diff/1/3 File chrome/browser/views/clear_browsing_data.cc (right): http://codereview.chromium.org/7946/diff/1/3#newcode313 Line ...

12 years, 2 months ago (2008-10-23 22:04:04 UTC) #2