Notify the WebView when panels gain/lose key window status.

Notify the WebView when panels gain/lose key window status.

BUG=none
TEST=switch between panels with a text input box.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102092

[dcheng, 2011-09-19 21:41:27]

I'd rather not check this in as is if possible. Any suggestions on how to share
code with BrowserWindowController?

[Dmitry Titov, 2011-09-19 22:18:09]

On 2011/09/19 21:41:27, dcheng wrote:
> I'd rather not check this in as is if possible. Any suggestions on how to
share
> code with BrowserWindowController?

I'm pretty sure this is not the last thing from BrowserWindowController that
we'll end up using... Pull things into common base class? Make current
BrowserWindowCocoa a MainBrowserWindowCocoa? Feel free to grab relevant folks
for design brainstorming session.

[dcheng, 2011-09-20 23:26:01]

Per our discussion, do you mind taking another look? I added a TODO for cleanup
in Q4.

[Dmitry Titov, 2011-09-20 23:35:59]

Nice. One nit:

http://codereview.chromium.org/7945018/diff/4001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/7945018/diff/4001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:430: if ([NSApp
isActive] && ([NSApp keyWindow] == [self window]))
could you figure out why we do these checks and add a comment?

[dcheng, 2011-09-20 23:47:10]

Now with more copy-and-paste than before.

[Dmitry Titov, 2011-09-21 00:40:54]

LGTM.

[commit-bot: I haz the power, 2011-09-21 09:07:20]

Change committed as 102092