Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3575)

Unified Diff: chrome/browser/chromeos/frame/panel_browser_view.cc

Issue 7945014: Applied review comments from oshima for CL 7850026. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/frame/panel_browser_view.cc
diff --git a/chrome/browser/chromeos/frame/panel_browser_view.cc b/chrome/browser/chromeos/frame/panel_browser_view.cc
index 7aa3ec2d8d574cf332a11298b20759c5bf926b8f..de39b0e8d2715e2698a12db5b259f4110e56cb1f 100644
--- a/chrome/browser/chromeos/frame/panel_browser_view.cc
+++ b/chrome/browser/chromeos/frame/panel_browser_view.cc
@@ -33,11 +33,6 @@ PanelBrowserView::~PanelBrowserView() {}
// PanelBrowserView functions
void PanelBrowserView::LimitBounds(gfx::Rect* bounds) const {
-#if defined(USE_AURA)
- // TODO(saintlou): Need PureViews panels?
- bounds->set_width(kPanelDefaultWidthPixels);
- bounds->set_height(kPanelDefaultHeightPixels);
-#else
GdkScreen* screen = gtk_widget_get_screen(GetWidget()->GetNativeView());
oshima 2011/09/19 22:31:03 What I meant was that you could comment out the en
Emmanuel Saint-loubert-Bié 2011/09/19 23:26:02 Done.
int max_width = gdk_screen_get_width(screen) * kPanelMaxWidthFactor;
int max_height = gdk_screen_get_height(screen) * kPanelMaxHeightFactor;
@@ -56,7 +51,6 @@ void PanelBrowserView::LimitBounds(gfx::Rect* bounds) const {
bounds->set_height(kPanelMinHeightPixels);
else if (bounds->height() > max_height)
bounds->set_height(max_height);
-#endif
}
@@ -107,12 +101,8 @@ void PanelBrowserView::UpdateTitleBar() {
void PanelBrowserView::SetCreatorView(PanelBrowserView* creator) {
DCHECK(creator);
-#if defined(USE_AURA)
- // TODO(saintlou): Need PureViews
-#else
oshima 2011/09/19 22:31:03 keep this.
Emmanuel Saint-loubert-Bié 2011/09/19 23:26:02 Done.
GtkWindow* window = creator->GetNativeHandle();
creator_xid_ = ui::GetX11WindowFromGtkWidget(GTK_WIDGET(window));
-#endif
}
WindowOpenDisposition PanelBrowserView::GetDispositionForPopupBounds(

Powered by Google App Engine
This is Rietveld 408576698