Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: chrome/browser/process_singleton.h

Issue 7945014: Applied review comments from oshima for CL 7850026. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PROCESS_SINGLETON_H_ 5 #ifndef CHROME_BROWSER_PROCESS_SINGLETON_H_
6 #define CHROME_BROWSER_PROCESS_SINGLETON_H_ 6 #define CHROME_BROWSER_PROCESS_SINGLETON_H_
7 #pragma once 7 #pragma once
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 160
161 // Path in file system to the cookie file. 161 // Path in file system to the cookie file.
162 FilePath cookie_path_; 162 FilePath cookie_path_;
163 163
164 // Temporary directory to hold the socket. 164 // Temporary directory to hold the socket.
165 ScopedTempDir socket_dir_; 165 ScopedTempDir socket_dir_;
166 166
167 // Helper class for linux specific messages. LinuxWatcher is ref counted 167 // Helper class for linux specific messages. LinuxWatcher is ref counted
168 // because it posts messages between threads. 168 // because it posts messages between threads.
169 #if !defined(USE_AURA) 169 #if !defined(USE_AURA)
170 // TODO(saintlou): LinuxWatcher is defined in process_singleton_linux.cc but
171 // not in process_singleton_aura.cc.
oshima 2011/09/19 22:31:03 why we don't need it on linux/aura?
Emmanuel Saint-loubert-Bié 2011/09/19 23:26:02 We probably need it eventually but process_singlet
oshima 2011/09/20 04:59:17 i see. thanks.
170 class LinuxWatcher; 172 class LinuxWatcher;
171 scoped_refptr<LinuxWatcher> watcher_; 173 scoped_refptr<LinuxWatcher> watcher_;
172 #endif 174 #endif
173 #elif defined(OS_MACOSX) 175 #elif defined(OS_MACOSX)
174 // Path in file system to the lock. 176 // Path in file system to the lock.
175 FilePath lock_path_; 177 FilePath lock_path_;
176 178
177 // File descriptor associated with the lockfile, valid between 179 // File descriptor associated with the lockfile, valid between
178 // |Create()| and |Cleanup()|. Two instances cannot have a lock on 180 // |Create()| and |Cleanup()|. Two instances cannot have a lock on
179 // the same file at the same time. 181 // the same file at the same time.
180 int lock_fd_; 182 int lock_fd_;
181 #endif 183 #endif
182 184
183 DISALLOW_COPY_AND_ASSIGN(ProcessSingleton); 185 DISALLOW_COPY_AND_ASSIGN(ProcessSingleton);
184 }; 186 };
185 187
186 #endif // CHROME_BROWSER_PROCESS_SINGLETON_H_ 188 #endif // CHROME_BROWSER_PROCESS_SINGLETON_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698