Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 7943006: Initialize message pump not to use gtk. WindowSizer for aura (Closed)

Created:
9 years, 3 months ago by oshima
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

Initialize message pump not to use gtk. This is a temp fix to remove gtk_init. We should remove this once we remove gtk from message pump, which should be done as a part of AURA->TOOLKIT_USES_GTK=0 WindowSizer/gfx::screen for aura BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101922

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -141 lines) Patch
A chrome/browser/ui/window_sizer_aura.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A + chrome/browser/ui/window_sizer_gtk.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/ui/window_sizer_linux.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/desktop.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/desktop.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M ui/gfx/screen_aura.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
9 years, 3 months ago (2011-09-19 18:05:10 UTC) #1
Emmanuel Saint-loubert-Bié
That change intriduces a new crash here: bool GetScreenWorkArea(gfx::Rect* out_rect) const { gboolean ok; guchar* ...
9 years, 3 months ago (2011-09-19 18:31:28 UTC) #2
oshima
Fixed DCHECK. aura-lized window-sizer and gfx::screen (aura window-sizer was necessary to remove gtk_init). PTAL.
9 years, 3 months ago (2011-09-19 21:56:02 UTC) #3
Emmanuel Saint-loubert-Bié
LGTM
9 years, 3 months ago (2011-09-19 22:34:06 UTC) #4
Ben Goodger (Google)
9 years, 3 months ago (2011-09-19 23:20:48 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698