GTTF: Make gclient recover gracefully from an interrupted checkout

gclient_scm.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 import logging
 import os
 import posixpath
 import re
@@ skipping 746 matching lines @@
     # Get the existing scm url and the revision number of the current checkout.
     try:
       from_info = scm.SVN.CaptureInfo(os.path.join(self.checkout_path, '.'))
     except (gclient_utils.Error, subprocess2.CalledProcessError):
       raise gclient_utils.Error(
           ('Can\'t update/checkout %s if an unversioned directory is present. '
            'Delete the directory and try again.') % self.checkout_path)
 
     # Look for locked directories.
     dir_info = scm.SVN.CaptureStatus(os.path.join(self.checkout_path, '.'))
-    for d in dir_info:
-      if d[0][2] == 'L':
-        self._Run(['cleanup', d[1]], options)
+    needs_cleanup = any(d[0][2] == 'L' for d in dir_info)
+    if needs_cleanup:

[M-A Ruel, 2011/09/20 20:55:33]

if any(d[0][2] == 'L' for d in dir_info):

+      try:
+        self._Run(['cleanup', self.checkout_path], options)
+      except subprocess2.CalledProcessError, e:
+        for d in dir_info:

[M-A Ruel, 2011/09/20 20:55:33]

Add comment:
# Try to manually clean up each individual files.

Also, I think you should grab status again.

+          if d[0][2] == 'L':
+            if d[0][0] == '!' and options.force:
+              print 'Removing troublesome path %s' % d[1]
+              gclient_utils.rmtree(d[1])
+            else:
+              print 'Not removing troublesome path %s automatically.' % d[1]
+              if d[0][0] == '!':
+                print 'You can pass --force to enable automatic removal.'
+              raise e
 
     # Retrieve the current HEAD version because svn is slow at null updates.
     if options.manually_grab_svn_rev and not revision:
       from_info_live = scm.SVN.CaptureInfo(from_info['URL'])
       revision = str(from_info_live['Revision'])
       rev_str = ' at %s' % revision
 
     if from_info['URL'] != base_url:
       # The repository url changed, need to switch.
       try:
@@ skipping 159 matching lines @@
 
     This method returns a new list to be used as a command."""
     new_command = command[:]
     if revision:
       new_command.extend(['--revision', str(revision).strip()])
     # --force was added to 'svn update' in svn 1.5.
     if ((options.force or options.manually_grab_svn_rev) and
         scm.SVN.AssertVersion("1.5")[0]):
       new_command.append('--force')
     return new_command