Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: views/ime/input_method_ibus.cc

Issue 7942004: Consolidate/cleanup event cracking code; single out GdkEvents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge removal of compact nav. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/ime/input_method_gtk.cc ('k') | views/native_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/ime/input_method_ibus.cc
diff --git a/views/ime/input_method_ibus.cc b/views/ime/input_method_ibus.cc
index ae22de2f6fe7467e749ac402757c3960ab7101ea..94ee14cba3086eb0ef50629b2318201f2c8f98b5 100644
--- a/views/ime/input_method_ibus.cc
+++ b/views/ime/input_method_ibus.cc
@@ -62,8 +62,8 @@ void IBusKeyEventFromViewsKeyEvent(const views::KeyEvent& key,
guint32* ibus_keycode,
guint32* ibus_state) {
#if defined(TOUCH_UI)
- if (key.native_event_2()) {
- XKeyEvent* x_key = reinterpret_cast<XKeyEvent*>(key.native_event_2());
+ if (key.native_event()) {
+ XKeyEvent* x_key = reinterpret_cast<XKeyEvent*>(key.native_event());
// Yes, ibus uses X11 keysym. We cannot use XLookupKeysym(), which doesn't
// translate Shift and CapsLock states.
KeySym keysym = NoSymbol;
@@ -72,8 +72,8 @@ void IBusKeyEventFromViewsKeyEvent(const views::KeyEvent& key,
*ibus_keycode = x_key->keycode;
}
#elif defined(TOOLKIT_USES_GTK)
- if (key.native_event()) {
- GdkEventKey* gdk_key = reinterpret_cast<GdkEventKey*>(key.native_event());
+ if (key.gdk_event()) {
+ GdkEventKey* gdk_key = reinterpret_cast<GdkEventKey*>(key.gdk_event());
*ibus_keyval = gdk_key->keyval;
*ibus_keycode = gdk_key->hardware_keycode;
}
@@ -223,8 +223,8 @@ InputMethodIBus::PendingKeyEvent::PendingKeyEvent(InputMethodIBus* input_method,
DCHECK(input_method_);
#if defined(TOUCH_UI)
- if (key.native_event_2())
- x_event_ = *reinterpret_cast<XKeyEvent*>(key.native_event_2());
+ if (key.native_event())
+ x_event_ = *reinterpret_cast<XKeyEvent*>(key.native_event());
else
memset(&x_event_, 0, sizeof(x_event_));
#endif
@@ -241,8 +241,7 @@ void InputMethodIBus::PendingKeyEvent::ProcessPostIME(bool handled) {
#if defined(TOUCH_UI)
if (x_event_.type == KeyPress || x_event_.type == KeyRelease) {
- Event::FromNativeEvent2 from_native;
- KeyEvent key(reinterpret_cast<XEvent*>(&x_event_), from_native);
+ KeyEvent key(reinterpret_cast<XEvent*>(&x_event_));
input_method_->ProcessKeyEventPostIME(key, ibus_keyval_, handled);
return;
}
« no previous file with comments | « views/ime/input_method_gtk.cc ('k') | views/native_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698