chrome/common/native_web_keyboard_event_views.cc - Issue 7942004: Consolidate/cleanup event cracking code; single out GdkEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/native_web_keyboard_event_views.cc

Issue 7942004: Consolidate/cleanup event cracking code; single out GdkEvents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix GdkEvent init, NativeWidgetGtk casting, and Get[Unmodified]Character checks. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/native_web_keyboard_event_views.cc

diff --git a/chrome/common/native_web_keyboard_event_views.cc b/chrome/common/native_web_keyboard_event_views.cc

index 4d0a5c90cc78e4cc4a7c03b69ce014dc4ff738d7..f36f6685b3598c33306a147395989cbe3408ff02 100644

--- a/chrome/common/native_web_keyboard_event_views.cc

+++ b/chrome/common/native_web_keyboard_event_views.cc

@@ -49,9 +49,9 @@ NativeWebKeyboardEventViews::NativeWebKeyboardEventViews(

// |os_event| is a MSG struct, so we can copy it directly.

os_event = event.native_event();

#elif defined(TOOLKIT_USES_GTK)

- if (event.native_event()) {

+ if (event.gdk_event()) {

os_event =

- reinterpret_cast<GdkEventKey*>(gdk_event_copy(event.native_event()));

+ reinterpret_cast<GdkEventKey*>(gdk_event_copy(event.gdk_event()));

nativeKeyCode = os_event->keyval;

} else {

os_event = NULL;