Issue 7941015: Wait for test script to be loaded before calling __get_timings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7941015: Wait for test script to be loaded before calling __get_timings (Closed)

Created:
9 years, 3 months ago by cmp

Modified:
9 years, 3 months ago

Reviewers:
Johnny(Jianning) Ding

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Wait for test script to be loaded before calling __get_timings Set a variable to indicate that the result report page is loaded. See detailed analysis in crbug.com/53140. This is relanding r101718 after a revert at r101778. BUG=53140 TBR=jnd@chromium.org TEST=page cycler stays green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101798

Patch Set 1 #

Patch Set 2 : fix copyright #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	chrome/test/perf/page_cycler_test.cc	View		2 chunks	+8 lines, -5 lines	0 comments	Download
	M	tools/page_cycler/common/head.js	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johnny(Jianning) Ding

9 years, 3 months ago (2011-09-20 02:14:02 UTC) #2

On 2011/09/19 19:52:27, cmp wrote:

LGTM. Thanks to fix it!

Expand Messages | Collapse Messages