Issue 7941010: Revert r101718 "wait for test script to be loaded"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7941010: Revert r101718 "wait for test script to be loaded" (Closed)

Created:
9 years, 3 months ago by cmp

Modified:
9 years, 3 months ago

Reviewers:
Johnny(Jianning) Ding

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert r101718 "wait for test script to be loaded" This change broke all of the page cycler tests on the chromium.perf waterfall. TBR=jnd@chromium.org BUG=53140 TEST=page cyclers work again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101778

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	chrome/test/perf/page_cycler_test.cc	View		2 chunks	+5 lines, -8 lines	0 comments	Download
	M	tools/page_cycler/common/head.js	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

What's happening on the bot is that a full page cycler test is run, it ...

9 years, 3 months ago (2011-09-19 18:17:09 UTC) #1

cmp

I'm guessing the internal DEPS needed to be rolled. I rolled them forward to pick ...

9 years, 3 months ago (2011-09-19 18:29:44 UTC) #2

Johnny(Jianning) Ding

9 years, 3 months ago (2011-09-20 01:57:47 UTC) #3

LGTM. Thanks to fix it!

On 2011/09/19 18:29:44, cmp wrote:
> I'm guessing the internal DEPS needed to be rolled.  I rolled them forward to
> pick up the test data changes.  I will wait for the bots to get green again
> before re-landing jnd's change to see if it works.
> 
> Johnny, if you get online, the bots are running the page cycler again, and
your
> change hasn't been relanded, feel free to reland it and make sure the tree
stays
> green.

Expand Messages | Collapse Messages