Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: chrome/browser/policy/file_based_policy_loader.h

Issue 7941008: Cosmetic cleanups in chrome/browser/policy/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanups and IWYU fixit in policy code Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/file_based_policy_loader.h
diff --git a/chrome/browser/policy/file_based_policy_loader.h b/chrome/browser/policy/file_based_policy_loader.h
index 4a2919c57f6ce9e8f13ebfb917bc014b2781248a..2c387c614eca4dcc13738bee6af38d681073a51d 100644
--- a/chrome/browser/policy/file_based_policy_loader.h
+++ b/chrome/browser/policy/file_based_policy_loader.h
@@ -6,10 +6,19 @@
#define CHROME_BROWSER_POLICY_FILE_BASED_POLICY_LOADER_H_
#pragma once
-#include "base/files/file_path_watcher.h"
+#include "base/compiler_specific.h"
+#include "base/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/time.h"
#include "chrome/browser/policy/asynchronous_policy_loader.h"
#include "chrome/browser/policy/file_based_policy_provider.h"
+namespace base {
+namespace files {
+class FilePathWatcher;
pastarmovj 2011/09/20 13:14:08 To be consistent with the rest why don't you put a
Joao da Silva 2011/09/20 18:51:17 Done.
+} // namespace files
+} // namespace base
+
namespace policy {
// A customized asynchronous policy loader that handles loading policy from a
@@ -18,11 +27,11 @@ namespace policy {
// the watched file is in flux.
class FileBasedPolicyLoader : public AsynchronousPolicyLoader {
public:
- FileBasedPolicyLoader(
+ explicit FileBasedPolicyLoader(
FileBasedPolicyProvider::ProviderDelegate* provider_delegate);
// AsynchronousPolicyLoader overrides:
- virtual void Reload();
+ virtual void Reload() OVERRIDE;
void OnFilePathChanged(const FilePath& path);
void OnFilePathError(const FilePath& path);
@@ -39,8 +48,8 @@ class FileBasedPolicyLoader : public AsynchronousPolicyLoader {
// Creates the file path watcher and configures it to watch
// |config_file_path_|. Must be called on the file thread.
- virtual void InitOnFileThread();
- virtual void StopOnFileThread();
+ virtual void InitOnFileThread() OVERRIDE;
+ virtual void StopOnFileThread() OVERRIDE;
private:
// Checks whether policy information is safe to read. If not, returns false

Powered by Google App Engine
This is Rietveld 408576698