Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 7941001: Added devtools.console.* and resource-related calls in inspectedWindow (Closed)

Created:
9 years, 3 months ago by caseq
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Added devtools.console.* and resource-related calls in inspectedWindow - added chrome.experimental.devtools.console.* - added getResources(), onResourceAdded event and Resource type in chrome.experimental.devtools.inspectedWindow BUG=none TEST=none

Patch Set 1 #

Total comments: 11

Patch Set 2 : review comments addressed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2103 lines, -263 lines) Patch
M chrome/common/extensions/api/devtools_api.json View 1 4 chunks +204 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.html View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/extensions/docs/experimental.devtools.console.html View 1 30 chunks +708 lines, -231 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html View 1 6 chunks +1164 lines, -30 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.network.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/experimental.devtools.console.html View 1 1 chunk +11 lines, -0 lines 1 comment Download
M chrome/common/extensions/docs/static/experimental.devtools.inspectedWindow.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq1
Live version: http://www.corp.google.com/~caseq/devtoolsext/docs/experimental.devtools.html
9 years, 3 months ago (2011-09-19 14:58:20 UTC) #1
kathyw
A few small issues. http://codereview.chromium.org/7941001/diff/1/chrome/common/extensions/api/devtools_api.json File chrome/common/extensions/api/devtools_api.json (right): http://codereview.chromium.org/7941001/diff/1/chrome/common/extensions/api/devtools_api.json#newcode12 chrome/common/extensions/api/devtools_api.json:12: "description": "An URL of the ...
9 years, 3 months ago (2011-09-19 16:28:28 UTC) #2
caseq
On 2011/09/19 16:28:28, kathyw wrote: > A few small issues. Thanks for the quick review ...
9 years, 3 months ago (2011-09-20 20:07:26 UTC) #3
kathyw
One little issue in the console description. Otherwise, LGTM. http://codereview.chromium.org/7941001/diff/7001/chrome/common/extensions/docs/static/experimental.devtools.console.html File chrome/common/extensions/docs/static/experimental.devtools.console.html (right): http://codereview.chromium.org/7941001/diff/7001/chrome/common/extensions/docs/static/experimental.devtools.console.html#newcode8 chrome/common/extensions/docs/static/experimental.devtools.console.html:8: ...
9 years, 3 months ago (2011-09-20 20:24:46 UTC) #4
caseq
9 years, 3 months ago (2011-09-21 08:47:50 UTC) #5
On 2011/09/20 20:24:46, kathyw wrote:
> One little issue in the console description. Otherwise, LGTM.

Thanks, fixed both and landed as r102089.

Powered by Google App Engine
This is Rietveld 408576698