Issue 794003: AU: Topological Sort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794003: AU: Topological Sort. (Closed)

Created:
10 years, 9 months ago by adlr

Modified:
9 years ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 4

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -0 lines)			Patch
M	src/platform/update_engine/SConstruct	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	src/platform/update_engine/topological_sort.h	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	src/platform/update_engine/topological_sort.cc	View	1 chunk	+39 lines, -0 lines	2 comments	Download
A	src/platform/update_engine/topological_sort_unittest.cc	View	1 chunk	+81 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM Finally, an algorithm that I know. :-P http://codereview.chromium.org/794003/diff/1/3 File src/platform/update_engine/topological_sort.cc (right): http://codereview.chromium.org/794003/diff/1/3#newcode14 src/platform/update_engine/topological_sort.cc:14: void ...

10 years, 9 months ago (2010-03-11 01:31:49 UTC) #2

adlr

10 years, 9 months ago (2010-03-11 04:12:08 UTC) #3

fixed and submitted. thanks!

http://codereview.chromium.org/794003/diff/1/3
File src/platform/update_engine/topological_sort.cc (right):

http://codereview.chromium.org/794003/diff/1/3#newcode14
src/platform/update_engine/topological_sort.cc:14: void
TopologicalSortVisit(const Graph& graph,
On 2010/03/11 01:31:49, Daniel Erat wrote:
> make this function static

did namespace {}

http://codereview.chromium.org/794003/diff/1/5
File src/platform/update_engine/topological_sort_unittest.cc (right):

http://codereview.chromium.org/794003/diff/1/5#newcode8
src/platform/update_engine/topological_sort_unittest.cc:8: #include
"chromeos/obsolete_logging.h"
On 2010/03/11 01:31:49, Daniel Erat wrote:
> you don't need this include, do you?  (noticed because i just removed
> libchromeos as a dependency for the window manager)

removed

Expand Messages | Collapse Messages

Issue 794003: AU: Topological Sort. (Closed)

Description

Patch Set 1 #

Messages