Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: src/arm/code-stubs-arm.h

Issue 7937004: Fix a harmless assert and a genuine bug in the GC-safety of stub (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 // so you don't have to set up the frame. 316 // so you don't have to set up the frame.
317 class WriteInt32ToHeapNumberStub : public CodeStub { 317 class WriteInt32ToHeapNumberStub : public CodeStub {
318 public: 318 public:
319 WriteInt32ToHeapNumberStub(Register the_int, 319 WriteInt32ToHeapNumberStub(Register the_int,
320 Register the_heap_number, 320 Register the_heap_number,
321 Register scratch) 321 Register scratch)
322 : the_int_(the_int), 322 : the_int_(the_int),
323 the_heap_number_(the_heap_number), 323 the_heap_number_(the_heap_number),
324 scratch_(scratch) { } 324 scratch_(scratch) { }
325 325
326 bool CompilingCallsToThisStubIsGCSafe();
327 static void GenerateStubsAheadOfTime();
328
326 private: 329 private:
327 Register the_int_; 330 Register the_int_;
328 Register the_heap_number_; 331 Register the_heap_number_;
329 Register scratch_; 332 Register scratch_;
330 333
331 // Minor key encoding in 16 bits. 334 // Minor key encoding in 16 bits.
332 class IntRegisterBits: public BitField<int, 0, 4> {}; 335 class IntRegisterBits: public BitField<int, 0, 4> {};
333 class HeapNumberRegisterBits: public BitField<int, 4, 4> {}; 336 class HeapNumberRegisterBits: public BitField<int, 4, 4> {};
334 class ScratchRegisterBits: public BitField<int, 8, 4> {}; 337 class ScratchRegisterBits: public BitField<int, 8, 4> {};
335 338
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 600
598 class LookupModeBits: public BitField<LookupMode, 0, 1> {}; 601 class LookupModeBits: public BitField<LookupMode, 0, 1> {};
599 602
600 LookupMode mode_; 603 LookupMode mode_;
601 }; 604 };
602 605
603 606
604 } } // namespace v8::internal 607 } } // namespace v8::internal
605 608
606 #endif // V8_ARM_CODE_STUBS_ARM_H_ 609 #endif // V8_ARM_CODE_STUBS_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698