Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 7935013: Implement verification of new space evacuation. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement verification of new space evacuation. R=vegorov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9408

Patch Set 1 #

Total comments: 2

Patch Set 2 : New space is not marked after evacuation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/mark-compact.cc View 1 6 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
PTAL. Not sure about the range of the new space to be verified. Currently the ...
9 years, 3 months ago (2011-09-19 10:08:20 UTC) #1
Vyacheslav Egorov (Chromium)
http://codereview.chromium.org/7935013/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7935013/diff/1/src/mark-compact.cc#newcode187 src/mark-compact.cc:187: VerifyEvacuation(page->body(), page->body_limit()); I doubt that this actually works. We ...
9 years, 3 months ago (2011-09-19 10:39:17 UTC) #2
Michael Starzinger
Added new patch set. http://codereview.chromium.org/7935013/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7935013/diff/1/src/mark-compact.cc#newcode187 src/mark-compact.cc:187: VerifyEvacuation(page->body(), page->body_limit()); On 2011/09/19 10:39:17, ...
9 years, 3 months ago (2011-09-19 13:02:59 UTC) #3
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-22 13:16:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698