Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7932022: Fix a deoptimization bug. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a deoptimization bug. We reset the count of outgoing arguments, used for the index in the frame's outgoing arguments, for each level of inlining. This could result in the arguments overlapping, rather than stacking on top of each other. R=whesse@chromium.org,fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-19 14:34:52 UTC) #1
William Hesse
9 years, 3 months ago (2011-09-19 22:41:34 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698