Displaying the extensions count in extensions settings page.

chrome/browser/resources/options/extension_settings.js

Index: chrome/browser/resources/options/extension_settings.js
diff --git a/chrome/browser/resources/options/extension_settings.js b/chrome/browser/resources/options/extension_settings.js
index 0beff40f775e64aa99950ada62541adc089fcf71..927afa0020311cf46c8f94a6b7bfc389d01b582e 100644
--- a/chrome/browser/resources/options/extension_settings.js
+++ b/chrome/browser/resources/options/extension_settings.js
@@ -153,6 +153,23 @@ cr.define('options', function() {
     $('suggest-gallery').hidden = true;
     $('get-more-extensions-container').hidden = true;
 
+    // Append extension count to extensionSettingsTitle and frame
+    // the extension header string .If there are no extensions loaded

[Finnur, 2011/09/19 13:49:56]

nit: Space is on the wrong side of the period.

+    //  then display Title as Extensions only.

[Finnur, 2011/09/19 13:49:56]

nit: Title should not be capitalized.

Actually, this can be reworded and shortened to: Show the extensions count (if
non-zero) in the header.

+    $('extension-settings-header').style.visibility = 'visible';
+    $('dev-toggle').style.visibility = 'visible';
+    var extensionSettingHeader;
+    if(extensionsData.extensions.length > 0) {

[Finnur, 2011/09/19 13:49:56]

style: Space after 'if' (before parentheses).

+      extensionSettingsHeader = templateData.extensionSettingsTitle
+                                  + " ("
+                                  + extensionsData.extensions.length
+                                  + ")";

[Finnur, 2011/09/19 13:49:56]

style: When you need to break long lines into multiple, the operators should
usually end the line, not begin them (move the plus up a line).

Also, the indentation is wrong. Either line the strings up on one line (up
against templateData.extensionSettingsTitle) or line them up 4 spaces to the
right of extensionSetttingsHeader.

+    }
+    else

[Finnur, 2011/09/19 13:49:56]

style: I believe if the 'if' clause has braces, the else should have it too.

+      extensionSettingsHeader = templateData.extensionSettingsTitle;
+
+    $('extension-settings-header').innerHTML = extensionSettingsHeader;

[Finnur, 2011/09/19 13:49:56]

use innerText, not innerHTML.

[naveenbobbili, 2011/09/19 14:43:18]

Sure. I will take a look at the styling guide lines and submit the patch with
your comments changes. 

+
     if (extensionsData.extensions.length > 0) {
       // Enforce order specified in the data or (if equal) then sort by
       // extension name (case-insensitive).