Displaying the extensions count in extensions settings page.

chrome/browser/resources/options/extension_settings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Used for observing function of the backend datasource for this page by
 // tests.
 var webui_responded_ = false;
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
@@ skipping 135 matching lines @@
    * Called by the dom_ui_ to re-populate the page with data representing
    * the current state of installed extensions.
    */
   ExtensionSettings.returnExtensionsData = function(extensionsData) {
     webui_responded_ = true;
 
     $('no-extensions').hidden = true;
     $('suggest-gallery').hidden = true;
     $('get-more-extensions-container').hidden = true;
 
+    // Append extension count to extensionSettingsTitle and frame
+    // the extension header string .If there are no extensions loaded

[Finnur, 2011/09/19 13:49:56]

nit: Space is on the wrong side of the period.

+    //  then display Title as Extensions only.

[Finnur, 2011/09/19 13:49:56]

nit: Title should not be capitalized.

Actually, this can be reworded and shortened to: Show the extensions count (if
non-zero) in the header.

+    $('extension-settings-header').style.visibility = 'visible';
+    $('dev-toggle').style.visibility = 'visible';
+    var extensionSettingHeader;
+    if(extensionsData.extensions.length > 0) {

[Finnur, 2011/09/19 13:49:56]

style: Space after 'if' (before parentheses).

+      extensionSettingsHeader = templateData.extensionSettingsTitle
+                                  + " ("
+                                  + extensionsData.extensions.length
+                                  + ")";

[Finnur, 2011/09/19 13:49:56]

style: When you need to break long lines into multiple, the operators should
usually end the line, not begin them (move the plus up a line).

Also, the indentation is wrong. Either line the strings up on one line (up
against templateData.extensionSettingsTitle) or line them up 4 spaces to the
right of extensionSetttingsHeader.

+    }
+    else

[Finnur, 2011/09/19 13:49:56]

style: I believe if the 'if' clause has braces, the else should have it too.

+      extensionSettingsHeader = templateData.extensionSettingsTitle;
+
+    $('extension-settings-header').innerHTML = extensionSettingsHeader;

[Finnur, 2011/09/19 13:49:56]

use innerText, not innerHTML.

[naveenbobbili, 2011/09/19 14:43:18]

Sure. I will take a look at the styling guide lines and submit the patch with
your comments changes. 

+
     if (extensionsData.extensions.length > 0) {
       // Enforce order specified in the data or (if equal) then sort by
       // extension name (case-insensitive).
       extensionsData.extensions.sort(function(a, b) {
         if (a.order == b.order) {
           a = a.name.toLowerCase();
           b = b.name.toLowerCase();
           return a < b ? -1 : (a > b ? 1 : 0);
         } else {
           return a.order < b.order ? -1 : 1;
@@ skipping 10 matching lines @@
 
     var extensionList = $('extension-settings-list');
     ExtensionsList.decorate(extensionList);
   }
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });