chrome/browser/resources/options/extension_settings.html - Issue 7932021: Displaying the extensions count in extensions settings page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/extension_settings.html

Issue 7932021: Displaying the extensions count in extensions settings page. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <div id="extension-settings" class="page" hidden>	1 <div id="extension-settings" class="page" hidden>

2 <h1 i18n-content="extensionSettingsTitle"></h1>	2 <h1 id="extension-settings-header" i18n-content="extensionSettingsTitle"

3 <div id="dev-toggle">	3 style="visibility:hidden"></h1>
	Finnur 2011/09/19 13:49:56 prefer: hidden="true" over the style attribute (as prefer: hidden="true" over the style attribute (as in lines 34-36). However, I'd prefer if you tried to add a new span inside the <h1>, which would contain the count and parentheses only. Then you don't need to modify the visibility of these elements and the count can appear after the page has loaded.
	4 <div id="dev-toggle" style="visibility:hidden">
	Finnur 2011/09/19 13:49:56 Why is this needed? Is this so it doesn't appear a Why is this needed? Is this so it doesn't appear at the top and then move down as the header becomes visible? naveenbobbili 2011/09/19 14:43:18 Yes this comes in the same line as the title. So i Show quoted text On 2011/09/19 13:49:56, Finnur wrote: > Why is this needed? Is this so it doesn't appear at the top and then move down > as the header becomes visible? Yes this comes in the same line as the title. So it will be weird to show it without showing the title. I hope I am clear.
4 <input id="toggle-dev-on" type="checkbox" value="off"></input>	5 <input id="toggle-dev-on" type="checkbox" value="off"></input>

5 <label for="toggle-dev-on" i18n-content="extensionSettingsDeveloperMode" />	6 <label for="toggle-dev-on" i18n-content="extensionSettingsDeveloperMode" />

6 </div>	7 </div>

7 <div class="displaytable">	8 <div class="displaytable">

8 <div id="dev" class="dev-closed">	9 <div id="dev" class="dev-closed">

9 <table id="dev-table" width="100%">	10 <table id="dev-table" width="100%">

10 <tr>	11 <tr>

11 <td>	12 <td>

12 <button id="load-unpacked"	13 <button id="load-unpacked"

13 i18n-content="extensionSettingsLoadUnpackedButton"></button>	14 i18n-content="extensionSettingsLoadUnpackedButton"></button>

(...skipping 17 matching lines...) Expand all Loading...
31 <div><strong id="no-extensions"	32 <div><strong id="no-extensions"

32 i18n-content="extensionSettingsNoExtensions"	33 i18n-content="extensionSettingsNoExtensions"

33 hidden="true"></strong></div>	34 hidden="true"></strong></div>

34 <div id="suggest-gallery" hidden="true"></div>	35 <div id="suggest-gallery" hidden="true"></div>

35 <div id="get-more-extensions-container" hidden="true">	36 <div id="get-more-extensions-container" hidden="true">

36 <image src="chrome://theme/IDR_WEBSTORE_ICON_32">	37 <image src="chrome://theme/IDR_WEBSTORE_ICON_32">

37 <div id="get-more-extensions"></div>	38 <div id="get-more-extensions"></div>

38 </div>	39 </div>

39 </section>	40 </section>

40 </div>	41 </div>

OLD	NEW

« AUTHORS ('K') | « AUTHORS ('k') | chrome/browser/resources/options/extension_settings.js » ('j') | chrome/browser/resources/options/extension_settings.js » ('J')