Refactoring recently closed tab filtering

chrome/browser/sessions/tab_restore_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_
 #define CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_
 #pragma once
 
 #include <list>
 #include <set>
@@ skipping 155 matching lines @@
   // Max number of entries we'll keep around.
   static const size_t kMaxEntries;
 
   // Creates and add entries to |entries| for each of the windows in |windows|.
   void CreateEntriesFromWindows(std::vector<SessionWindow*>* windows,
                                 std::vector<Entry*>* entries);
 
  protected:
   virtual void Save();
 
+  // Set of entries.
+  Entries entries_;

[noyau (Ping after 24h), 2011/09/20 15:46:58]

I had to move the entries to be protected in order to be able to construct a
mock for testing purpose.

[sky, 2011/09/20 16:24:46]

Use entries() instead of making this field protected.

[noyau (Ping after 24h), 2011/09/20 17:09:35]

Reverted as this class is no longer mocked.

+
  private:
   // Used to indicate what has loaded.
   enum LoadState {
     // Indicates we haven't loaded anything.
     NOT_LOADED           = 1 << 0,
 
     // Indicates we've asked for the last sessions and tabs but haven't gotten
     // the result back yet.
     LOADING              = 1 << 2,
 
@@ skipping 107 matching lines @@
       Window* window);
 
   // Invoked when previous tabs or session is loaded. If both have finished
   // loading the entries in staging_entries_ are added to entries_ and
   // observers are notified.
   void LoadStateChanged();
 
   // Gets the current time. This uses the time_factory_ if there is one.
   base::Time TimeNow() const;
 
-  // Set of entries.
-  Entries entries_;
-
   // Whether we've loaded the last session.
   int load_state_;
 
   // Are we restoring a tab? If this is true we ignore requests to create a
   // historical tab.
   bool restoring_;
 
   // Have the max number of entries ever been created?
   bool reached_max_;
 
@@ skipping 21 matching lines @@
   // loading LoadStateChanged is invoked, which adds these entries to
   // entries_.
   std::vector<Entry*> staging_entries_;
 
   TimeFactory* time_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TabRestoreService);
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_