Refactoring recently closed tab filtering

chrome/browser/sessions/tab_restore_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_
 #define CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_
 #pragma once
 
 #include <list>
 #include <set>
@@ skipping 128 matching lines @@
   void BrowserClosed(TabRestoreServiceDelegate* delegate);
 
   // Removes all entries from the list and notifies observers the list
   // of tabs has changed.
   void ClearEntries();
 
   // Returns the entries, ordered with most recently closed entries at the
   // front.
   virtual const Entries& entries() const;
 
+  // Fill the passed list with the entries filtering out the ones that are on
+  // the same URL as a previous entry. This avoid filling the list with things
+  // that look like duplicates. A user can still access the filtered out version
+  // by restoring the one he sees as it will allow the older one to show.
+  void FilteredEntries(TabRestoreService::Entries* filteredEntries) const;

[sky, 2011/09/19 16:23:15]

If this is only going to be used by RecentlyClosedTabHandler I would rather see
the code there. If that isn't the case pull this into a static method on a class
name like SessionUtil in this directory.

[sky, 2011/09/19 20:58:17]

When you move this to a separate class make the method take a const Entries&.
That'll be easier to write tests for.

[noyau (Ping after 24h), 2011/09/20 15:46:58]

This will be used in some other context. SessionUtils created.

+
   // Restores the most recently closed entry. Does nothing if there are no
   // entries to restore. If the most recently restored entry is a tab, it is
   // added to |delegate|.
   void RestoreMostRecentEntry(TabRestoreServiceDelegate* delegate);
 
   // Restores an entry by id. If there is no entry with an id matching |id|,
   // this does nothing. If |replace_existing_tab| is true and id identifies a
   // tab, the newly created tab replaces the selected tab in |delegate|. If
   // |delegate| is NULL, this creates a new window for the entry.
   void RestoreEntryById(TabRestoreServiceDelegate* delegate,
@@ skipping 178 matching lines @@
   // loading LoadStateChanged is invoked, which adds these entries to
   // entries_.
   std::vector<Entry*> staging_entries_;
 
   TimeFactory* time_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TabRestoreService);
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_TAB_RESTORE_SERVICE_H_