Prevent clang from optimizing away 2 variables.

Prevent clang from optimizing away 2 variables.

Hopefully fixes Memcheck sanity tests 12 and 13.

BUG=96945
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101698

[Timur Iskhodzhanov, 2011-09-18 08:38:34]

Can you please add a comment describing why one shouldn't omit volatile?
Then LGTM
17.09.2011 9:24 пользователь <thakis@chromium.org> написал:
> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Prevent clang from optimizing away 2 variables.
>
> Hopefully fixes Memcheck sanity tests 12 and 13.
>
> BUG=96945
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7931006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M base/tools_sanity_unittest.cc
>
>
> Index: base/tools_sanity_unittest.cc
> diff --git a/base/tools_sanity_unittest.cc b/base/tools_sanity_unittest.cc
> index
>
64a9ca68f1878431713960c7a2a41a95abacbfa2..4a33617b1f984b71ce92fc47d5d47ec2139fb086

> 100644
> --- a/base/tools_sanity_unittest.cc
> +++ b/base/tools_sanity_unittest.cc
> @@ -84,7 +84,7 @@ TEST(ToolsSanityTest, ArrayDeletedWithoutBraces) {
> if (!RunningOnValgrind())
> return;
>
> - int *foo = new int[10];
> + int* volatile foo = new int[10];
> delete foo;
> }
>
> @@ -93,7 +93,7 @@ TEST(ToolsSanityTest, SingleElementDeletedWithBraces) {
> if (!RunningOnValgrind())
> return;
>
> - int *foo = new int;
> + int* volatile foo = new int;
> delete [] foo;
> }
>
>
>

[commit-bot: I haz the power, 2011-09-18 16:27:56]

Presubmit check for 7931006-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/tools_sanity_unittest.cc