views: Make mouse state member variables private to Widget.

views: Make mouse state member variables private to Widget.

Note: This was a TODO for msw@.

R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102102

[Ben Goodger (Google), 2011-09-19 20:31:59]

http://codereview.chromium.org/7930014/diff/1/views/widget/widget.h
File views/widget/widget.h (left):

http://codereview.chromium.org/7930014/diff/1/views/widget/widget.h#oldcode620
views/widget/widget.h:620: bool is_mouse_button_pressed_;
How about these other members too? I'd rather move them all to private in one
swoop.

[tfarina, 2011-09-19 20:44:02]

http://codereview.chromium.org/7930014/diff/1/views/widget/widget.h
File views/widget/widget.h (left):

http://codereview.chromium.org/7930014/diff/1/views/widget/widget.h#oldcode620
views/widget/widget.h:620: bool is_mouse_button_pressed_;
On 2011/09/19 20:31:59, Ben Goodger (Google) wrote:
> How about these other members too?
They are still used by NativeWidgetGtk.

> I'd rather move them all to private in one
> swoop.

[Ben Goodger (Google), 2011-09-19 21:07:10]

NativeWidgetGtk isn't a subclass of Widget though, so I am curious as to how
it could be using a protected field.

-Ben

On Mon, Sep 19, 2011 at 1:44 PM, <tfarina@chromium.org> wrote:

>
>
http://codereview.chromium.**org/7930014/diff/1/views/**widget/widget.h<http:...
> File views/widget/widget.h (left):
>
> http://codereview.chromium.**org/7930014/diff/1/views/**
>
widget/widget.h#oldcode620<http://codereview.chromium.org/7930014/diff/1/views/widget/widget.h#oldcode620>
> views/widget/widget.h:620: bool is_mouse_button_pressed_;
> On 2011/09/19 20:31:59, Ben Goodger (Google) wrote:
>
>> How about these other members too?
>>
> They are still used by NativeWidgetGtk.
>
>
>  I'd rather move them all to private in one
>> swoop.
>>
>
>
http://codereview.chromium.**org/7930014/<http://codereview.chromium.org/7930...
>

[tfarina, 2011-09-19 21:10:49]

On 2011/09/19 21:07:10, Ben Goodger (Google) wrote:
> NativeWidgetGtk isn't a subclass of Widget though, so I am curious as to how
> it could be using a protected field.
> 
I think it's because we declare Widget as friend class of NativeWidgetGtk (line
606).

[tfarina, 2011-09-20 02:16:45]

Since we have this friendship between Widget and NativeWidgetGtk, they don't
need to be in the protected section and can be made private to Widget.

Please, could you take another look?

[Ben Goodger (Google), 2011-09-20 18:18:31]

lgtm