Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: chrome/browser/policy/url_blacklist_manager.h

Issue 7930011: Readability review for joaodasilva (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/policy/url_blacklist_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/url_blacklist_manager.h
diff --git a/chrome/browser/policy/url_blacklist_manager.h b/chrome/browser/policy/url_blacklist_manager.h
index c085973a185760251740761e6ab5049e75c7084f..e3b7f25a741e7f801575082008e5da108ab332b7 100644
--- a/chrome/browser/policy/url_blacklist_manager.h
+++ b/chrome/browser/policy/url_blacklist_manager.h
@@ -39,7 +39,8 @@ class URLBlacklist {
URLBlacklist();
virtual ~URLBlacklist();
- // URLs matching |filter| will be blocked.
+ // URLs matching |filter| will be blocked. The filter format is documented
+ // at http://www.chromium.org/administrators/url-blacklist-filter-format
void Block(const std::string& filter);
// URLs matching |filter| will be allowed. If |filter| is both Blocked and
@@ -65,20 +66,7 @@ class URLBlacklist {
uint16* port,
std::string* path);
private:
- struct PathFilter {
- explicit PathFilter(const std::string& path, uint16 port, bool match)
- : path_prefix(path),
- port(port),
- blocked_schemes(0),
- allowed_schemes(0),
- match_subdomains(match) {}
-
- std::string path_prefix;
- uint16 port;
- uint8 blocked_schemes;
- uint8 allowed_schemes;
- bool match_subdomains;
- };
+ struct PathFilter;
typedef std::vector<PathFilter> PathFilterList;
typedef base::hash_map<std::string, PathFilterList*> HostFilterTable;
« no previous file with comments | « no previous file | chrome/browser/policy/url_blacklist_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698