Implement RunSubprocessChain to allow the tools call several processes connected by pipes.

Implement RunSubprocessChain to allow the tools call several processes connected by pipes.

[Alexander Potapenko, 2011-09-16 14:48:57]

Hi M-A,

Are you the right person to do the review, or should I ask Erik?

[M-A Ruel, 2011-09-16 14:57:48]

http://codereview.chromium.org/7926011/diff/1/tools/valgrind/common.py
File tools/valgrind/common.py (right):

http://codereview.chromium.org/7926011/diff/1/tools/valgrind/common.py#newcode98
tools/valgrind/common.py:98: if timeout > 0:
You should seriously consider using subprocess2, it already has the timeout
logic unit tested on all platforms.

I'm also considering implementing tee-like support, I just had a few issues on
windows I had to cleanup first..

[Alexander Potapenko, 2011-09-16 15:06:42]

> You should seriously consider using subprocess2, it already has the timeout
> logic unit tested on all platforms.
I'll take a look, thank you.
 
> I'm also considering implementing tee-like support, I just had a few issues on
> windows I had to cleanup first..
Were you going to do that for tools/valgrind?

BTW, something similar with syntax like [[proc1, proc2], [proc3]] is used by our
buildbots, isn't it?

[M-A Ruel, 2011-09-16 15:18:02]

On 2011/09/16 15:06:42, Alexander Potapenko wrote:
> > You should seriously consider using subprocess2, it already has the timeout
> > logic unit tested on all platforms.
> I'll take a look, thank you.
>  
> > I'm also considering implementing tee-like support, I just had a few issues
on
> > windows I had to cleanup first..
> Were you going to do that for tools/valgrind?

Well, it there is need for it outside depot_tools, I'll increase the priority of
this feature.

> BTW, something similar with syntax like [[proc1, proc2], [proc3]] is used by
our
> buildbots, isn't it?

I don't understand the question.