chrome/browser/resources/options/options_page_touchui.css - Issue 7926010: Fix X button size of subpage for touch ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/options_page_touchui.css

Issue 7926010: Fix X button size of subpage for touch ui (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 .close-subpage {
	Rick Byers 2011/09/16 14:29:27 I know it's not in all CSS files, but you should p I know it's not in all CSS files, but you should probably add a copyright header to this new file,like: /* * Copyright (c) 2011 The Chromium Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. / Rick Byers* 2011/09/16 14:29:27 I'd suggest adding a small comment above the selec I'd suggest adding a small comment above the selector like the following: /* In TOUCH_UI builds, the IDR_CLOSE_BAR resource is double-size. / It's a little confusing that one resource comes in different sizes for different builds... bshe* 2011/09/16 15:22:07 Done. Show quoted text On 2011/09/16 14:29:27, Rick Byers wrote: > I know it's not in all CSS files, but you should probably add a copyright header > to this new file,like: > > /* > * Copyright (c) 2011 The Chromium Authors. All rights reserved. > * Use of this source code is governed by a BSD-style license that can be > * found in the LICENSE file. > / Done. bshe* 2011/09/16 15:22:07 Done. Show quoted text On 2011/09/16 14:29:27, Rick Byers wrote: > I'd suggest adding a small comment above the selector like the following: > /* In TOUCH_UI builds, the IDR_CLOSE_BAR resource is double-size. */ > > It's a little confusing that one resource comes in different sizes for different > builds... Done.
	2 background-image: url('chrome://theme/IDR_CLOSE_BAR');
	Rick Byers 2011/09/16 14:29:27 you shouldn't have to repeat this property - you'r you shouldn't have to repeat this property - you're just trying to override height and width. Try removing all lines except height and width - it should behave the same without them. bshe 2011/09/16 15:22:07 Done. Show quoted text On 2011/09/16 14:29:27, Rick Byers wrote: > you shouldn't have to repeat this property - you're just trying to override > height and width. Try removing all lines except height and width - it should > behave the same without them. Done.
	3 height: 32px;

	4 min-width: 0;

	5 position: relative;

	6 top: 16px;

	7 width: 32px;

	8 }

OLD	NEW

« no previous file with comments | « chrome/browser/resources/options/options.html ('k') | no next file » | no next file with comments »