Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7719)

Unified Diff: chrome/browser/sync/js/js_sync_manager_observer.h

Issue 7926001: [Sync] Move change-related methods out of SyncManager::Observer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/js/js_sync_manager_observer.h
diff --git a/chrome/browser/sync/js/js_sync_manager_observer.h b/chrome/browser/sync/js/js_sync_manager_observer.h
index 98d4d597e620d8ad9ae280d72db51640f9ffac3a..d48e8f274a30434e0f4c85f219b2f1910773ff88 100644
--- a/chrome/browser/sync/js/js_sync_manager_observer.h
+++ b/chrome/browser/sync/js/js_sync_manager_observer.h
@@ -24,19 +24,23 @@ class JsEventDetails;
class JsEventHandler;
// Routes SyncManager events to a JsEventHandler.
-class JsSyncManagerObserver : public sync_api::SyncManager::Observer {
+class JsSyncManagerObserver
+ : public sync_api::SyncManager::ChangeObserver,
+ public sync_api::SyncManager::Observer {
public:
JsSyncManagerObserver();
virtual ~JsSyncManagerObserver();
void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler);
- // sync_api::SyncManager::Observer implementation.
+ // sync_api::SyncManager::ChangeObserver implementation.
virtual void OnChangesApplied(
syncable::ModelType model_type,
- const sync_api::BaseTransaction* trans,
+ int64 write_transaction_id,
const sync_api::ImmutableChangeRecordList& changes) OVERRIDE;
virtual void OnChangesComplete(syncable::ModelType model_type) OVERRIDE;
+
+ // sync_api::SyncManager::Observer implementation.
virtual void OnSyncCycleCompleted(
const sessions::SyncSessionSnapshot* snapshot) OVERRIDE;
virtual void OnAuthError(const GoogleServiceAuthError& auth_error) OVERRIDE;
« no previous file with comments | « chrome/browser/sync/internal_api/syncapi_unittest.cc ('k') | chrome/browser/sync/js/js_sync_manager_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698