[Sync] Move change-related methods out of SyncManager::Observer

chrome/browser/sync/syncable/syncable.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/syncable/syncable.h"
 
 #include "build/build_config.h"
 
 #include <sys/stat.h>
 #if defined(OS_POSIX)
@@ skipping 72 matching lines @@
     ENUM_CASE(VACUUM_AFTER_SAVE);
     ENUM_CASE(PURGE_ENTRIES);
     ENUM_CASE(SYNCAPI);
   };
   NOTREACHED();
   return "";
 }
 
 #undef ENUM_CASE
 
-namespace {
-
 DictionaryValue* EntryKernelMutationToValue(
     const EntryKernelMutation& mutation) {
   DictionaryValue* dict = new DictionaryValue();
   dict->Set("original", mutation.original.ToValue());
   dict->Set("mutated", mutation.mutated.ToValue());
   return dict;
 }
 
-}  // namespace
-
 ListValue* EntryKernelMutationMapToValue(
     const EntryKernelMutationMap& mutations) {
   ListValue* list = new ListValue();
   for (EntryKernelMutationMap::const_iterator it = mutations.begin();
        it != mutations.end(); ++it) {
     list->Append(EntryKernelMutationToValue(it->second));
   }
   return list;
 }
 
@@ skipping 1126 matching lines @@
 }
 
 ModelTypeBitSet WriteTransaction::NotifyTransactionChangingAndEnding(
     const ImmutableEntryKernelMutationMap& mutations) {
   dirkernel_->transaction_mutex.AssertAcquired();
   DCHECK(!mutations.Get().empty());
 
   DirectoryChangeDelegate* const delegate = dirkernel_->delegate;
   if (writer_ == syncable::SYNCAPI) {
     delegate->HandleCalculateChangesChangeEventFromSyncApi(
-        mutations.Get(), this);
+        mutations, this);
   } else {
     delegate->HandleCalculateChangesChangeEventFromSyncer(
-        mutations.Get(), this);
+        mutations, this);
   }
 
   ModelTypeBitSet models_with_changes =
-      delegate->HandleTransactionEndingChangeEvent(this);
+      delegate->HandleTransactionEndingChangeEvent(mutations, this);
 
   dirkernel_->observers->Notify(
       &TransactionObserver::OnTransactionMutate,
       from_here_, writer_, mutations, models_with_changes);
 
   return models_with_changes;
 }
 
 void WriteTransaction::NotifyTransactionComplete(
     ModelTypeBitSet models_with_changes) {
@@ skipping 672 matching lines @@
   CHECK(result);
   for (iterator i = GetParentChildIndexLowerBound(lock, parent_id),
            end = GetParentChildIndexUpperBound(lock, parent_id);
        i != end; ++i) {
     DCHECK_EQ(parent_id, (*i)->ref(PARENT_ID));
     result->push_back((*i)->ref(META_HANDLE));
   }
 }
 
 }  // namespace syncable