[Sync] Move change-related methods out of SyncManager::Observer

chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/js/js_sync_manager_observer.h"
 
 #include <cstddef>
 
 #include "base/basictypes.h"
 #include "base/message_loop.h"
 #include "base/tracked.h"
 #include "base/values.h"
 #include "chrome/browser/sync/internal_api/read_node.h"
 #include "chrome/browser/sync/internal_api/read_transaction.h"
 #include "chrome/browser/sync/internal_api/write_node.h"
 #include "chrome/browser/sync/internal_api/write_transaction.h"
 #include "chrome/browser/sync/js/js_arg_list.h"
 #include "chrome/browser/sync/js/js_event_details.h"
 #include "chrome/browser/sync/js/js_test_util.h"
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
 #include "chrome/browser/sync/sessions/session_state.h"
 #include "chrome/browser/sync/syncable/model_type.h"
+#include "chrome/browser/sync/syncable/syncable.h"
 #include "chrome/browser/sync/test/engine/test_user_share.h"
 #include "chrome/browser/sync/util/weak_handle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace browser_sync {
 namespace {
 
 using ::testing::InSequence;
 using ::testing::StrictMock;
 
@@ skipping 292 matching lines @@
   for (int i = syncable::AUTOFILL_PROFILE;
        i < syncable::MODEL_TYPE_COUNT; ++i) {
     const std::string& model_type_str =
         syncable::ModelTypeToString(syncable::ModelTypeFromInt(i));
     DictionaryValue expected_details;
     expected_details.SetString("modelType", model_type_str);
     ListValue* expected_changes = new ListValue();
     expected_details.Set("changes", expected_changes);
     for (int j = i; j < syncable::MODEL_TYPE_COUNT; ++j) {
       sync_api::ReadTransaction trans(FROM_HERE, test_user_share.user_share());
-      expected_changes->Append(changes[j].ToValue(&trans));
+      expected_changes->Append(changes[j].ToValue(
+          syncable::ImmutableEntryKernelMutationMap()));
     }
     EXPECT_CALL(mock_js_event_handler_,
                 HandleJsEvent("onChangesApplied",
                              HasDetailsAsDictionary(expected_details)));
   }
 
   // Fire OnChangesApplied() for each data type.
   for (int i = syncable::AUTOFILL_PROFILE;
        i < syncable::MODEL_TYPE_COUNT; ++i) {
     sync_api::ReadTransaction trans(FROM_HERE, test_user_share.user_share());
     sync_api::ChangeRecordList
         local_changes(changes + i, changes + arraysize(changes));
     js_sync_manager_observer_.OnChangesApplied(
         syncable::ModelTypeFromInt(i),
-        &trans,
+        syncable::ImmutableEntryKernelMutationMap(),
         sync_api::ImmutableChangeRecordList(&local_changes));
   }
 
   test_user_share.TearDown();
   PumpLoop();
 }
 
 }  // namespace
 }  // namespace browser_sync