Support for |change| argument to |GetPreferredTrySlaves()|.

Support for |change| argument to |GetPreferredTrySlaves()|.

Needed to make it so changes containing only *.mm are only sent to Mac trybots by default.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102783

[Alexei Svitkine (slow), 2011-09-21 17:32:30]

Marc-Antoine,

Can you take a look and give me some preliminary comments on how this looks.

I want to add this support for git-cl too, not just gcl and probably add a test
for this. Any suggestions on these fronts are welcome!

Thanks.

[M-A Ruel, 2011-09-21 17:47:35]

In general it looks fine to me.

For git-cl, it's a batch of shell scripts.

It will break with the -R flag. I'm not sure what's the best thing to do for
that. The -R flag is a bit crappy in any case.

http://codereview.chromium.org/7925014/diff/4003/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/7925014/diff/4003/presubmit_support.py#newcode903
presubmit_support.py:903: result = get_preferred_try_slaves(project, change)
So GetPreferredTrySlaves has to handle when change is None?

[Alexei Svitkine (slow), 2011-09-26 17:29:44]

Could you take another look?

I've updated the CL to support 'git try' and just ./trychange.py invocations.

[M-A Ruel, 2011-09-26 17:48:34]

mostly lgtm, I'm just unsure about SetFileTuples()

http://codereview.chromium.org/7925014/diff/10009/trychange.py
File trychange.py (right):

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode195
trychange.py:195: def SetFileTuples(self, file_tuples):
I'd rather have self.files and self.file_tuples be a @property and have it lazy
loaded as needed. wdyt?

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode703
trychange.py:703: if options.name is None:
if not options.name:

Not sure why it was the other form before.

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode713
trychange.py:713: else:
actually, remove the else, since the parser.error() call quits anyway.

[Alexei Svitkine (slow), 2011-09-26 18:14:06]

http://codereview.chromium.org/7925014/diff/10009/trychange.py
File trychange.py (right):

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode195
trychange.py:195: def SetFileTuples(self, file_tuples):
On 2011/09/26 17:48:34, Marc-Antoine Ruel wrote:
> I'd rather have self.files and self.file_tuples be a @property and have it
lazy
> loaded as needed. wdyt?

Like so?

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode703
trychange.py:703: if options.name is None:
On 2011/09/26 17:48:34, Marc-Antoine Ruel wrote:
> if not options.name:
> 
> Not sure why it was the other form before.

Done.

http://codereview.chromium.org/7925014/diff/10009/trychange.py#newcode713
trychange.py:713: else:
On 2011/09/26 17:48:34, Marc-Antoine Ruel wrote:
> actually, remove the else, since the parser.error() call quits anyway.

Done.

[M-A Ruel, 2011-09-26 18:18:50]

lgtm

http://codereview.chromium.org/7925014/diff/12008/trychange.py
File trychange.py (right):

http://codereview.chromium.org/7925014/diff/12008/trychange.py#newcode114
trychange.py:114: def GetFileTuples(self):
Not needed. GetFileNames() was poor taste but it's too late to remove anyway.

[commit-bot: I haz the power, 2011-09-26 19:15:45]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/7925014/10012

[commit-bot: I haz the power, 2011-09-26 19:21:35]

Presubmit check for 7925014-10012 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module tests.trychange_unittest
C0301: 62,0: Line too long (85/80)
C0301: 86,0: Line too long (85/80)
************* Module trychange
W0312:733,0: Found indentation with tabs instead of spaces
E1101:208,0:SCM.files: Instance of 'SCM' has no 'CaptureStatus' member
E1101:214,0:SCM.file_tuples: Instance of 'SCM' has no 'CaptureStatus' member
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

tests/trychange_unittest.py failed!
Command tests/trychange_unittest.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.['GetFileTuples']
F.['GetFileTuples']
F.
======================================================================
FAIL: testMembersChanged (__main__.GITUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/pymox/mox.py",
line 1618, in new_method
    func(self, *args, **kwargs)
  File "tests/trychange_unittest.py", line 90, in testMembersChanged
    self.compareMembers(trychange.GIT, members)
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/super_mox.py",
line 78, in compareMembers
    self.assertEqual(actual_members, expected_members)
AssertionError: ['AutomagicalSettings', 'CaptureStatus', 'GenerateDiff',
'GetCodeReviewSetting', 'GetFileNames', 'ReadRootFile', 'file_tuples', 'files']
!= ['AutomagicalSettings', 'CaptureStatus', 'GenerateDiff',
'GetCodeReviewSetting', 'GetFileNames', 'GetFileTuples', 'ReadRootFile',
'file_tuples', 'files']

======================================================================
FAIL: testMembersChanged (__main__.SVNUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/pymox/mox.py",
line 1618, in new_method
    func(self, *args, **kwargs)
  File "tests/trychange_unittest.py", line 66, in testMembersChanged
    self.compareMembers(trychange.SVN, members)
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/super_mox.py",
line 78, in compareMembers
    self.assertEqual(actual_members, expected_members)
AssertionError: ['AutomagicalSettings', 'CaptureStatus', 'GenerateDiff',
'GetCodeReviewSetting', 'GetFileNames', 'ReadRootFile', 'file_tuples', 'files']
!= ['AutomagicalSettings', 'CaptureStatus', 'GenerateDiff',
'GetCodeReviewSetting', 'GetFileNames', 'GetFileTuples', 'ReadRootFile',
'file_tuples', 'files']

----------------------------------------------------------------------
Ran 5 tests in 0.010s

FAILED (failures=2)


Presubmit checks took 345.9s to calculate.

[commit-bot: I haz the power, 2011-09-26 19:29:51]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/7925014/12009

[commit-bot: I haz the power, 2011-09-26 19:35:36]

Presubmit check for 7925014-12009 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module trychange
W0312:733,0: Found indentation with tabs instead of spaces
E1101:208,0:SCM.files: Instance of 'SCM' has no 'CaptureStatus' member
E1101:214,0:SCM.file_tuples: Instance of 'SCM' has no 'CaptureStatus' member
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 341.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2011-09-26 19:43:05]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/7925014/10013

[commit-bot: I haz the power, 2011-09-26 19:48:36]

Presubmit check for 7925014-10013 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module trychange
C0301:206,0: Line too long (88/80)
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 328.2s to calculate.

[M-A Ruel, 2011-09-26 19:49:30]

http://codereview.chromium.org/7925014/diff/10013/trychange.py
File trychange.py (right):

http://codereview.chromium.org/7925014/diff/10013/trychange.py#newcode206
trychange.py:206: """Returns the 'svn status' emulated output as an array of
(status, file) tuples."""
I guess you should switch of text editor. :)

[commit-bot: I haz the power, 2011-09-26 19:52:42]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/7925014/11018

[commit-bot: I haz the power, 2011-09-26 19:58:23]

Change committed as 102783

[M-A Ruel, 2011-09-26 20:06:05]

On 2011/09/26 19:58:23, I haz the power (commit-bot) wrote:
> Change committed as 102783

This broke support on python2.5.

http://docs.python.org/library/inspect.html notes that the named properties like
'.args' are new in 2.6.

I'll fix.

[Alexei Svitkine (slow), 2011-09-26 20:09:43]

Sorry... :(

On Mon, Sep 26, 2011 at 4:06 PM, <maruel@chromium.org> wrote:

> On 2011/09/26 19:58:23, I haz the power (commit-bot) wrote:
>
>> Change committed as 102783
>>
>
> This broke support on python2.5.
>
>
http://docs.python.org/**library/inspect.html<http://docs.python.org/library/...
that the named properties like
> '.args' are new in 2.6.
>
> I'll fix.
>
>
>
http://codereview.chromium.**org/7925014/<http://codereview.chromium.org/7925...
>