Issue 7925007: Enable inlining functions with contexts different than their caller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7925007: Enable inlining functions with contexts different than their caller. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
fschneider, William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Enable inlining functions with contexts different than their caller. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9421

Patch Set 1 #

Patch Set 2 : Merged with HEAD> #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	src/hydrogen.cc	View	1	2 chunks	+8 lines, -1 line	1 comment	Download
	M	src/ia32/lithium-codegen-ia32.cc	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

This is IA32 only for now. There is a rare performance regression that can be ...

9 years, 3 months ago (2011-09-22 10:40:28 UTC) #2

fschneider

9 years, 3 months ago (2011-09-23 13:15:31 UTC) #3

LGTM.

http://codereview.chromium.org/7925007/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7925007/diff/2001/src/hydrogen.cc#newcode4506
src/hydrogen.cc:4506: 
Extra newline.

Expand Messages | Collapse Messages