Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 7925006: NativeWidgetViews: Implement Maximize. (Closed)

Created:
9 years, 3 months ago by sadrul
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

NativeWidgetViews: Implement Maximize. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102330

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : update restored bounds when not maximized/minimized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M views/widget/native_widget_views.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M views/widget/native_widget_views.cc View 1 2 4 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
9 years, 3 months ago (2011-09-19 20:05:39 UTC) #1
sky
http://codereview.chromium.org/7925006/diff/1/views/widget/native_widget_views.cc File views/widget/native_widget_views.cc (right): http://codereview.chromium.org/7925006/diff/1/views/widget/native_widget_views.cc#newcode428 views/widget/native_widget_views.cc:428: minimized_ = true; Could we use an enum to ...
9 years, 3 months ago (2011-09-19 20:32:47 UTC) #2
sadrul
http://codereview.chromium.org/7925006/diff/1/views/widget/native_widget_views.cc File views/widget/native_widget_views.cc (right): http://codereview.chromium.org/7925006/diff/1/views/widget/native_widget_views.cc#newcode428 views/widget/native_widget_views.cc:428: minimized_ = true; On 2011/09/19 20:32:47, sky wrote: > ...
9 years, 3 months ago (2011-09-22 17:00:24 UTC) #3
sky
http://codereview.chromium.org/7925006/diff/5001/views/widget/native_widget_views.cc File views/widget/native_widget_views.cc (right): http://codereview.chromium.org/7925006/diff/5001/views/widget/native_widget_views.cc#newcode416 views/widget/native_widget_views.cc:416: restored_bounds_ = view_->bounds(); Should we only do this if ...
9 years, 3 months ago (2011-09-22 17:59:10 UTC) #4
sadrul
http://codereview.chromium.org/7925006/diff/5001/views/widget/native_widget_views.cc File views/widget/native_widget_views.cc (right): http://codereview.chromium.org/7925006/diff/5001/views/widget/native_widget_views.cc#newcode416 views/widget/native_widget_views.cc:416: restored_bounds_ = view_->bounds(); On 2011/09/22 17:59:10, sky wrote: > ...
9 years, 3 months ago (2011-09-22 18:24:45 UTC) #5
sky
9 years, 3 months ago (2011-09-22 19:18:48 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698