Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 7925: Addressing Ivan's comments of using INVALID_TYPE in Factory::CreateApiFunctio... (Closed)

Created:
12 years, 2 months ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Addressing Ivan's comments of using INVALID_TYPE in Factory::CreateApiFunction. Committed: http://code.google.com/p/v8/source/detail?r=575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Feng Qian
12 years, 2 months ago (2008-10-23 18:25:51 UTC) #1
iposva
12 years, 2 months ago (2008-10-23 18:27:09 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698