chrome/common/chrome_content_client.h - Issue 7922023: Remove webkit_glue::BuildUserAgent(), remove windows spoofing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_content_client.h

Issue 7922023: Remove webkit_glue::BuildUserAgent(), remove windows spoofing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix GetUserAgent() to return whether the user agent is overriding, clean up Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/chrome_content_client.h

diff --git a/chrome/common/chrome_content_client.h b/chrome/common/chrome_content_client.h

index a4bb24279d7c55a2d155753c09b0c4a794965eb7..40a7deaa50f0c21b6696ba7b1a15a3a3187aeeae 100644

--- a/chrome/common/chrome_content_client.h

+++ b/chrome/common/chrome_content_client.h

@@ -21,7 +21,7 @@ class ChromeContentClient : public content::ContentClient {

virtual void AddPepperPlugins(std::vector<PepperPluginInfo>* plugins);

virtual bool CanSendWhileSwappedOut(const IPC::Message* msg);

virtual bool CanHandleWhileSwappedOut(const IPC::Message& msg);

- virtual std::string GetUserAgent(bool mimic_windows) const;

+ virtual std::string GetUserAgent(bool *overriding) const;

Evan Martin 2011/09/21 20:27:24 star on the left

Evan Martin 2011/09/21 20:27:24 Can you add OVERRIDE here to help ensure that you

Dirk Pranke 2011/09/21 21:02:35 Will fix the star ... I forgot about OVERRIDE. All

virtual string16 GetLocalizedString(int message_id) const;

virtual base::StringPiece GetDataResource(int resource_id) const;