Remove webkit_glue::BuildUserAgent(), remove windows spoofing

webkit/glue/user_agent.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_GLUE_USER_AGENT_H_
 #define WEBKIT_GLUE_USER_AGENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 
 namespace webkit_glue {
 
 // Builds a User-agent compatible string that describes the OS and CPU type.
 std::string BuildOSCpuInfo();
 
 // Returns the WebKit version, in the form "major.minor (branch@revision)".
 std::string GetWebKitVersion();
 
 // The following 2 functions return the major and minor webkit versions.
 int GetWebKitMajorVersion();
 int GetWebKitMinorVersion();
 
 // Helper function to generate the user agent.
-// - If mimic_windows is true, produce a fake Windows Chrome string..
-std::string BuildUserAgentHelper(bool mimic_windows,
-                                 const std::string& product);
+std::string BuildUserAgentHelper(const std::string& product);

[Evan Martin, 2011/09/21 20:27:24]

It's not exactly your problem, but the word "Helper" in this function name is
completely uninformative.  I pre-LGTM any change you have that might make it
clearer.  (As well as documenting what "product" means here.)

[Dirk Pranke, 2011/09/21 21:02:35]

Agreed it's not a great name. I will attempt to fix it.

 }  // namespace webkit_glue
 
 #endif  // WEBKIT_GLUE_USER_AGENT_H_