Remove webkit_glue::BuildUserAgent(), remove windows spoofing

content/common/content_client.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_CONTENT_CLIENT_H_
 #define CONTENT_COMMON_CONTENT_CLIENT_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 58 matching lines @@
   virtual void AddPepperPlugins(std::vector<PepperPluginInfo>* plugins) = 0;
 
   // Returns whether the given message should be allowed to be sent from a
   // swapped out renderer.
   virtual bool CanSendWhileSwappedOut(const IPC::Message* msg) = 0;
 
   // Returns whether the given message should be processed in the browser on
   // behalf of a swapped out renderer.
   virtual bool CanHandleWhileSwappedOut(const IPC::Message& msg) = 0;
 
-  // Returns the user agent. If mimic_windows is true then the embedder can
-  // return a fake Windows user agent. This is a workaround for broken
-  // websites.
-  virtual std::string GetUserAgent(bool mimic_windows) const = 0;
+  // Returns the user agent and indicates whether this string should
+  // always be used (overriding any hacks to work around browser sniffing).
+  virtual std::string GetUserAgent(bool *overriding) const = 0;

[Evan Martin, 2011/09/21 20:27:24]

star on the left

I don't quite get the doc: when overriding is true, it's saying I should always
obey the returned user agent?  As opposed to it being optional?

[Dirk Pranke, 2011/09/21 21:02:35]

That is correct. I will attempt to make it clearer, but suggestions are welcome.

 
   // Returns a string resource given its id.
   virtual string16 GetLocalizedString(int message_id) const = 0;
 
   // Return the contents of a resource in a StringPiece given the resource id.
   virtual base::StringPiece GetDataResource(int resource_id) const = 0;
 
 #if defined(OS_WIN)
   // Allows the embedder to sandbox a plugin, and apply a custom policy.
   virtual bool SandboxPlugin(CommandLine* command_line,
                              sandbox::TargetPolicy* policy) = 0;
 #endif
 
  private:
   // The embedder API for participating in browser logic.
   ContentBrowserClient* browser_;
   // The embedder API for participating in plugin logic.
   ContentPluginClient* plugin_;
   // The embedder API for participating in renderer logic.
   ContentRendererClient* renderer_;
   // The embedder API for participating in utility logic.
   ContentUtilityClient* utility_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_CONTENT_CLIENT_H_