Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 7922011: Continue conversion to more properties. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Continue conversion to more properties. Make Dependency.file_list a tuple so it can't be modified. Move the guesswork of file_list at the right place. Remove tree() since it's unnecessary. R=dpranke@chromium.org BUG= TEST=all smoke tests still pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -46 lines) Patch
M gclient.py View 13 chunks +65 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-16 17:15:12 UTC) #1
Dirk Pranke
lgtm
9 years, 3 months ago (2011-09-16 22:29:10 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-09-20 14:11:43 UTC) #3
Change committed as 101951

Powered by Google App Engine
This is Rietveld 408576698