Issue 7922006: mac: Turn style plugin on by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7922006: mac: Turn style plugin on by default. (Closed)

Created:
9 years, 3 months ago by Nico

Modified:
9 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

mac: Turn style plugin on by default. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101494

Patch Set 1 #

Patch Set 2 : mac mac mac #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

9 years, 3 months ago (2011-09-16 13:46:47 UTC) #2

LGTM otherwise.

http://codereview.chromium.org/7922006/diff/3/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7922006/diff/3/build/common.gypi#newcode217
build/common.gypi:217: # Use Skia as WebKit renderer on Mac
This comment seems sort of misplaced now that you’re recycling this condition
for more than a single purpose.

Expand Messages | Collapse Messages