Fix duplicate rule for LASTCHANGE

Fix duplicate rule for LASTCHANGE

BUG=None
TEST=build it on linux (make/ninja), check no warning of duplicate rule


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101793

[Peter Kasting, 2011-09-16 23:16:25]

The idea behind this seems good to me.  I don't know enough to do a real review
on whether you implemented it right.  If you actually need that you'll have to
find someone else.  If not, then rubber-stamp LGTM.

[piman, 2011-09-17 00:37:38]

On 2011/09/16 23:16:25, Peter Kasting wrote:
> The idea behind this seems good to me.  I don't know enough to do a real
review
> on whether you implemented it right.  If you actually need that you'll have to
> find someone else.  If not, then rubber-stamp LGTM.

I'm fairly confident since I implemented the toolset mechanism in gyp :)

The problem is that we essentially had 2 rules that generated the same file (one
for host, one for target). So I removed the 'host' version, and made sure
everything that depends on it explicitly depends on the 'target' version
(instead of the 'corresponding' version, e.g. the 'host' version of lastchange
when you build the 'host' version of base).

[commit-bot: I haz the power, 2011-09-17 00:38:12]

Presubmit check for 7920025-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/base.gypi

Presubmit checks took 1.8s to calculate.

[piman, 2011-09-17 00:39:10]

+darin for base/ OWNERS

[darin (slow to review), 2011-09-19 06:15:21]

LGTM, but that's just a rubber stamp.  I am not a GYP-master.  Seems like maybe
you should get bradnelson to review this?

[piman, 2011-09-19 07:22:23]

+bradnelson in case he has anything to say.

[bradn, 2011-09-19 17:07:44]

lgtm

[commit-bot: I haz the power, 2011-09-19 19:20:43]

Change committed as 101793