Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 7920023: Fix crashes related to the extension uninstall dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make Show() pure virtual Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_model.cc
diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc
index c0d870f85a1a99473c1cdae79a0bef96069e239b..fd9207bb4112b3069c5d9b0049ae76df4886fb9b 100644
--- a/chrome/browser/extensions/extension_context_menu_model.cc
+++ b/chrome/browser/extensions/extension_context_menu_model.cc
@@ -131,8 +131,9 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
}
case UNINSTALL: {
AddRef(); // Balanced in Accepted() and Canceled()
- extension_uninstall_dialog_.reset(new ExtensionUninstallDialog(profile_));
- extension_uninstall_dialog_->ConfirmUninstall(this, extension);
+ extension_uninstall_dialog_.reset(
+ ExtensionUninstallDialog::Create(profile_, this));
+ extension_uninstall_dialog_->ConfirmUninstall(extension);
break;
}
case MANAGE: {
@@ -149,7 +150,7 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
}
}
-void ExtensionContextMenuModel::ExtensionDialogAccepted() {
+void ExtensionContextMenuModel::ExtensionUninstallAccepted() {
if (GetExtension())
profile_->GetExtensionService()->UninstallExtension(extension_id_, false,
NULL);
@@ -157,7 +158,7 @@ void ExtensionContextMenuModel::ExtensionDialogAccepted() {
Release();
}
-void ExtensionContextMenuModel::ExtensionDialogCanceled() {
+void ExtensionContextMenuModel::ExtensionUninstallCanceled() {
Release();
}
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.h ('k') | chrome/browser/extensions/extension_install_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698