Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/ui/webui/options/extension_settings_handler.h

Issue 7920023: Fix crashes related to the extension uninstall dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make Show() pure virtual Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 base::DictionaryValue* localized_strings) OVERRIDE; 138 base::DictionaryValue* localized_strings) OVERRIDE;
139 virtual void Initialize() OVERRIDE; 139 virtual void Initialize() OVERRIDE;
140 140
141 // NotificationObserver implementation. 141 // NotificationObserver implementation.
142 virtual void Observe(int type, 142 virtual void Observe(int type,
143 const NotificationSource& source, 143 const NotificationSource& source,
144 const NotificationDetails& details) OVERRIDE; 144 const NotificationDetails& details) OVERRIDE;
145 145
146 // ExtensionUninstallDialog::Delegate implementation, used for receiving 146 // ExtensionUninstallDialog::Delegate implementation, used for receiving
147 // notification about uninstall confirmation dialog selections. 147 // notification about uninstall confirmation dialog selections.
148 virtual void ExtensionDialogAccepted() OVERRIDE; 148 virtual void ExtensionUninstallAccepted() OVERRIDE;
149 virtual void ExtensionDialogCanceled() OVERRIDE; 149 virtual void ExtensionUninstallCanceled() OVERRIDE;
150 150
151 private: 151 private:
152 // Helper that lists the current active html pages for an extension. 152 // Helper that lists the current active html pages for an extension.
153 std::vector<ExtensionPage> GetActivePagesForExtension( 153 std::vector<ExtensionPage> GetActivePagesForExtension(
154 const Extension* extension); 154 const Extension* extension);
155 void GetActivePagesForExtensionProcess( 155 void GetActivePagesForExtensionProcess(
156 RenderProcessHost* process, 156 RenderProcessHost* process,
157 const Extension* extension, 157 const Extension* extension,
158 std::vector<ExtensionPage> *result); 158 std::vector<ExtensionPage> *result);
159 159
(...skipping 28 matching lines...) Expand all
188 // We want to register for notifications only after we've responded at least 188 // We want to register for notifications only after we've responded at least
189 // once to the page, otherwise we'd be calling javacsript functions on objects 189 // once to the page, otherwise we'd be calling javacsript functions on objects
190 // that don't exist yet when notifications come in. This variable makes sure 190 // that don't exist yet when notifications come in. This variable makes sure
191 // we do so only once. 191 // we do so only once.
192 bool registered_for_notifications_; 192 bool registered_for_notifications_;
193 193
194 DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler); 194 DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler);
195 }; 195 };
196 196
197 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_ 197 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | chrome/browser/ui/webui/options/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698