Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm

Issue 7920023: Fix crashes related to the extension uninstall dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"
6 6
7 #include "base/sys_string_conversions.h" 7 #include "base/sys_string_conversions.h"
8 #include "base/task.h" 8 #include "base/task.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/extensions/extension_tabs_module.h" 10 #include "chrome/browser/extensions/extension_tabs_module.h"
11 #include "chrome/browser/extensions/extension_uninstall_dialog.h" 11 #include "chrome/browser/extensions/extension_uninstall_ui.h"
12 #include "chrome/browser/prefs/pref_change_registrar.h" 12 #include "chrome/browser/prefs/pref_change_registrar.h"
13 #include "chrome/browser/prefs/pref_service.h" 13 #include "chrome/browser/prefs/pref_service.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/browser_list.h" 15 #include "chrome/browser/ui/browser_list.h"
16 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 16 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
17 #include "chrome/browser/ui/cocoa/browser_window_controller.h" 17 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
18 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 18 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
19 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h" 19 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
20 #include "chrome/browser/ui/cocoa/info_bubble_view.h" 20 #include "chrome/browser/ui/cocoa/info_bubble_view.h"
21 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 21 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
22 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" 22 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
23 #include "chrome/common/chrome_notification_types.h" 23 #include "chrome/common/chrome_notification_types.h"
24 #include "chrome/common/extensions/extension.h" 24 #include "chrome/common/extensions/extension.h"
25 #include "chrome/common/extensions/extension_action.h" 25 #include "chrome/common/extensions/extension_action.h"
26 #include "chrome/common/extensions/extension_constants.h" 26 #include "chrome/common/extensions/extension_constants.h"
27 #include "chrome/common/pref_names.h" 27 #include "chrome/common/pref_names.h"
28 #include "chrome/common/url_constants.h" 28 #include "chrome/common/url_constants.h"
29 #include "content/common/notification_details.h" 29 #include "content/common/notification_details.h"
30 #include "content/common/notification_observer.h" 30 #include "content/common/notification_observer.h"
31 #include "content/common/notification_source.h" 31 #include "content/common/notification_source.h"
32 #include "grit/generated_resources.h" 32 #include "grit/generated_resources.h"
33 #include "ui/base/l10n/l10n_util_mac.h" 33 #include "ui/base/l10n/l10n_util_mac.h"
34 34
35 // A class that loads the extension icon on the I/O thread before showing the 35 // A class that loads the extension icon on the I/O thread before showing the
36 // confirmation dialog to uninstall the given extension. 36 // confirmation dialog to uninstall the given extension.
37 // Also acts as the extension's UI delegate in order to display the dialog. 37 // Also acts as the extension's UI delegate in order to display the dialog.
38 class AsyncUninstaller : public ExtensionUninstallDialog::Delegate { 38 class AsyncUninstaller : public ExtensionUninstallUI::Delegate {
39 public: 39 public:
40 AsyncUninstaller(const Extension* extension, Profile* profile) 40 AsyncUninstaller(const Extension* extension, Profile* profile)
41 : extension_(extension), 41 : extension_(extension),
42 profile_(profile) { 42 profile_(profile) {
43 extension_uninstall_dialog_.reset(new ExtensionUninstallDialog(profile)); 43 extension_uninstall_ui_.reset(new ExtensionUninstallUI(profile));
44 extension_uninstall_dialog_->ConfirmUninstall(this, extension_); 44 extension_uninstall_ui_->ConfirmUninstall(this, extension_);
45 } 45 }
46 46
47 ~AsyncUninstaller() {} 47 ~AsyncUninstaller() {}
48 48
49 // ExtensionUninstallDialog::Delegate: 49 // ExtensionUninstallUI::Delegate:
50 virtual void ExtensionDialogAccepted() { 50 virtual void ExtensionUninstallAccepted() {
51 profile_->GetExtensionService()-> 51 profile_->GetExtensionService()->
52 UninstallExtension(extension_->id(), false, NULL); 52 UninstallExtension(extension_->id(), false, NULL);
53 } 53 }
54 virtual void ExtensionDialogCanceled() {} 54 virtual void ExtensionUninstallCanceled() {}
55 55
56 private: 56 private:
57 // The extension that we're loading the icon for. Weak. 57 // The extension that we're loading the icon for. Weak.
58 const Extension* extension_; 58 const Extension* extension_;
59 59
60 // The current profile. Weak. 60 // The current profile. Weak.
61 Profile* profile_; 61 Profile* profile_;
62 62
63 scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_; 63 scoped_ptr<ExtensionUninstallUI> extension_uninstall_ui_;
64 64
65 DISALLOW_COPY_AND_ASSIGN(AsyncUninstaller); 65 DISALLOW_COPY_AND_ASSIGN(AsyncUninstaller);
66 }; 66 };
67 67
68 namespace extension_action_context_menu { 68 namespace extension_action_context_menu {
69 69
70 class DevmodeObserver : public NotificationObserver { 70 class DevmodeObserver : public NotificationObserver {
71 public: 71 public:
72 DevmodeObserver(ExtensionActionContextMenu* menu, 72 DevmodeObserver(ExtensionActionContextMenu* menu,
73 PrefService* service) 73 PrefService* service)
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 } 315 }
316 return YES; 316 return YES;
317 } 317 }
318 318
319 - (void)invalidateProfile { 319 - (void)invalidateProfile {
320 observer_.reset(); 320 observer_.reset();
321 profile_ = NULL; 321 profile_ = NULL;
322 } 322 }
323 323
324 @end 324 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698