Issue 7920019: Add PowerLibrary::RequestStatusUpdate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7920019: Add PowerLibrary::RequestStatusUpdate (Closed)

Created:
9 years, 3 months ago by stevenjb

Modified:
9 years, 3 months ago

Reviewers:
DaveMoore, satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add PowerLibrary::RequestStatusUpdate BUG=chromium-os:20533 TEST=Ensure battery icon behaves correctly in ChromeOS, and clicking on it does not cause a noticible delay. When running with --stub-cros clicking the icon should toggle cycling behavior for testing UI. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101777

Patch Set 1 #

Patch Set 2 : default initial percentage -> 80 #

Patch Set 3 : Remove deprecated libcros call. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -6 lines)			Patch
M	chrome/browser/chromeos/cros/mock_power_library.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/power_library.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/power_library.cc	View	1 2	3 chunks	+24 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/status/power_menu_button.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Pulled RequestStatusUpdate changes from http://codereview.chromium.org/7891021/ into a separate CL.

9 years, 3 months ago (2011-09-16 21:17:12 UTC) #1

stevenjb

PTAL Turns out the libcros call I found is deprecated. Rather than implement it or ...

9 years, 3 months ago (2011-09-19 17:23:12 UTC) #3

LGTM

Expand Messages | Collapse Messages