Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 7920012: Add missing NaCl PPAPI test components to Chrome repo. (Closed)

Created:
9 years, 3 months ago by noelallen1
Modified:
9 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add missing NaCl PPAPI test components to Chrome repo. This CL does not affect Chrome yet. It is the first part of a multi CL dance between NaCl and Chrome repos. It only adds missing files which a later CL to NaCl (followed by a later NaCl DEPS bump in chrome) will change the location from which certain files are built. Eventually a TRY will verify that components can still be compiled and tested. Adds examples.html & nacl.scons removing references to SRCP (non PPAPI) tests. Adds earth test. Adds srpcgen tool which is called from the Chrome repo. Adds trusted and untrusted PPAPI build files. BUG= http://code.google.com/p/chromium/issues/detail?id=96782 TEST= none (no effect) R= bradnelson@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2191 lines, -0 lines) Patch
A ppapi/native_client/src/shared/ppapi/build.scons View 1 chunk +36 lines, -0 lines 0 comments Download
A ppapi/native_client/src/shared/ppapi/nacl.scons View 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/native_client/src/tools/srpcgen.py View 1 chunk +467 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/README.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth.cc View 1 chunk +830 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth_c.html View 1 chunk +57 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth_c.nmf View 1 chunk +7 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth_c.nmf.dsoexample View 1 chunk +30 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth_cc.html View 1 chunk +58 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/earth_cc.nmf View 1 chunk +7 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/nacl.scons View 1 chunk +89 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/pepper_c.c View 1 chunk +225 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/earth/pepper_cc.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/examples.html View 1 chunk +107 lines, -0 lines 0 comments Download
A ppapi/native_client/tests/nacl.scons View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
9 years, 3 months ago (2011-09-16 18:24:38 UTC) #1
bradn
LGTM, did you decide against dropping the underlay?
9 years, 3 months ago (2011-09-16 18:27:56 UTC) #2
noelallen_use_chromium
I ran into errors with getting rid of the scons and gyp files (in the ...
9 years, 3 months ago (2011-09-16 18:41:11 UTC) #3
bradn
K, sounds wise. On Fri, Sep 16, 2011 at 11:40 AM, Noel Allen <noelallen@google.com> wrote: ...
9 years, 3 months ago (2011-09-16 18:42:17 UTC) #4
sehr (please use chromium)
9 years, 3 months ago (2011-09-16 18:56:42 UTC) #5
LGTM.

On 2011/09/16 18:42:17, bradn wrote:
> K, sounds wise.
> 
> 
> On Fri, Sep 16, 2011 at 11:40 AM, Noel Allen <mailto:noelallen@google.com>
wrote:
> 
> > I ran into errors with getting rid of the scons and gyp files (in the
> > gyp case an exception because I'm "above" the native_client
> > directory), so I unwound that part.  I will try again, but I'm just
> > doing this in smaller steps.
> >
> > On Fri, Sep 16, 2011 at 11:27 AM,  <mailto:bradnelson@google.com> wrote:
> > > LGTM, did you decide against dropping the underlay?
> > >
> > >
> > > http://codereview.chromium.org/7920012/
> > >
> >

Powered by Google App Engine
This is Rietveld 408576698