Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 7920006: Fix asserts and GC unsafeness in stub generation, bug=1689. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/mozilla/mozilla.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 77
78 #define __ masm()-> 78 #define __ masm()->
79 79
80 bool LCodeGen::GenerateCode() { 80 bool LCodeGen::GenerateCode() {
81 HPhase phase("Code generation", chunk()); 81 HPhase phase("Code generation", chunk());
82 ASSERT(is_unused()); 82 ASSERT(is_unused());
83 status_ = GENERATING; 83 status_ = GENERATING;
84 84
85 // Open a frame scope to indicate that there is a frame on the stack. The 85 // Open a frame scope to indicate that there is a frame on the stack. The
86 // MANUAL indicates that the scope shouldn't actually generate code to set up 86 // MANUAL indicates that the scope shouldn't actually generate code to set up
87 // the frame (that is done in GeneatePrologue). 87 // the frame (that is done in GeneratePrologue).
88 FrameScope frame_scope(masm_, StackFrame::MANUAL); 88 FrameScope frame_scope(masm_, StackFrame::MANUAL);
89 89
90 return GeneratePrologue() && 90 return GeneratePrologue() &&
91 GenerateBody() && 91 GenerateBody() &&
92 GenerateDeferredCode() && 92 GenerateDeferredCode() &&
93 GenerateJumpTable() && 93 GenerateJumpTable() &&
94 GenerateSafepointTable(); 94 GenerateSafepointTable();
95 } 95 }
96 96
97 97
(...skipping 4056 matching lines...) Expand 10 before | Expand all | Expand 10 after
4154 RegisterEnvironmentForDeoptimization(environment); 4154 RegisterEnvironmentForDeoptimization(environment);
4155 ASSERT(osr_pc_offset_ == -1); 4155 ASSERT(osr_pc_offset_ == -1);
4156 osr_pc_offset_ = masm()->pc_offset(); 4156 osr_pc_offset_ = masm()->pc_offset();
4157 } 4157 }
4158 4158
4159 #undef __ 4159 #undef __
4160 4160
4161 } } // namespace v8::internal 4161 } } // namespace v8::internal
4162 4162
4163 #endif // V8_TARGET_ARCH_X64 4163 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/mozilla/mozilla.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698