Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 7920006: Fix asserts and GC unsafeness in stub generation, bug=1689. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 65
66 #define __ masm()-> 66 #define __ masm()->
67 67
68 bool LCodeGen::GenerateCode() { 68 bool LCodeGen::GenerateCode() {
69 HPhase phase("Code generation", chunk()); 69 HPhase phase("Code generation", chunk());
70 ASSERT(is_unused()); 70 ASSERT(is_unused());
71 status_ = GENERATING; 71 status_ = GENERATING;
72 CpuFeatures::Scope scope(SSE2); 72 CpuFeatures::Scope scope(SSE2);
73 73
74 CodeStub::GenerateFPStubs();
75
74 // Open a frame scope to indicate that there is a frame on the stack. The 76 // Open a frame scope to indicate that there is a frame on the stack. The
75 // MANUAL indicates that the scope shouldn't actually generate code to set up 77 // MANUAL indicates that the scope shouldn't actually generate code to set up
76 // the frame (that is done in GeneratePrologue). 78 // the frame (that is done in GeneratePrologue).
77 FrameScope frame_scope(masm_, StackFrame::MANUAL); 79 FrameScope frame_scope(masm_, StackFrame::MANUAL);
78 80
79 return GeneratePrologue() && 81 return GeneratePrologue() &&
80 GenerateBody() && 82 GenerateBody() &&
81 GenerateDeferredCode() && 83 GenerateDeferredCode() &&
82 GenerateSafepointTable(); 84 GenerateSafepointTable();
83 } 85 }
(...skipping 4300 matching lines...) Expand 10 before | Expand all | Expand 10 after
4384 env->deoptimization_index()); 4386 env->deoptimization_index());
4385 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4387 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4386 } 4388 }
4387 4389
4388 4390
4389 #undef __ 4391 #undef __
4390 4392
4391 } } // namespace v8::internal 4393 } } // namespace v8::internal
4392 4394
4393 #endif // V8_TARGET_ARCH_IA32 4395 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698