Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 7920006: Fix asserts and GC unsafeness in stub generation, bug=1689. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 76
77 #define __ masm()-> 77 #define __ masm()->
78 78
79 bool LCodeGen::GenerateCode() { 79 bool LCodeGen::GenerateCode() {
80 HPhase phase("Code generation", chunk()); 80 HPhase phase("Code generation", chunk());
81 ASSERT(is_unused()); 81 ASSERT(is_unused());
82 status_ = GENERATING; 82 status_ = GENERATING;
83 CpuFeatures::Scope scope1(VFP3); 83 CpuFeatures::Scope scope1(VFP3);
84 CpuFeatures::Scope scope2(ARMv7); 84 CpuFeatures::Scope scope2(ARMv7);
85 85
86 CodeStub::GenerateFPStubs();
87
86 // Open a frame scope to indicate that there is a frame on the stack. The 88 // Open a frame scope to indicate that there is a frame on the stack. The
87 // NONE indicates that the scope shouldn't actually generate code to set up 89 // NONE indicates that the scope shouldn't actually generate code to set up
88 // the frame (that is done in GeneatePrologue). 90 // the frame (that is done in GeneratePrologue).
89 FrameScope frame_scope(masm_, StackFrame::NONE); 91 FrameScope frame_scope(masm_, StackFrame::NONE);
90 92
91 return GeneratePrologue() && 93 return GeneratePrologue() &&
92 GenerateBody() && 94 GenerateBody() &&
93 GenerateDeferredCode() && 95 GenerateDeferredCode() &&
94 GenerateDeoptJumpTable() && 96 GenerateDeoptJumpTable() &&
95 GenerateSafepointTable(); 97 GenerateSafepointTable();
96 } 98 }
97 99
98 100
(...skipping 4417 matching lines...) Expand 10 before | Expand all | Expand 10 after
4516 ASSERT(osr_pc_offset_ == -1); 4518 ASSERT(osr_pc_offset_ == -1);
4517 osr_pc_offset_ = masm()->pc_offset(); 4519 osr_pc_offset_ = masm()->pc_offset();
4518 } 4520 }
4519 4521
4520 4522
4521 4523
4522 4524
4523 #undef __ 4525 #undef __
4524 4526
4525 } } // namespace v8::internal 4527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698