Fix asserts and GC unsafeness in stub generation, bug=1689.

src/arm/code-stubs-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3163 matching lines @@
                                                     Register scratch) {
   Isolate* isolate = masm->isolate();
 
   __ push(lr);
   __ PrepareCallCFunction(0, 1, scratch);
   if (masm->use_eabi_hardfloat()) {
     __ vmov(d0, d2);
   } else {
     __ vmov(r0, r1, d2);
   }
+  AllowExternalCallThatCantCauseGC scope(masm);
   switch (type_) {
     case TranscendentalCache::SIN:
       __ CallCFunction(ExternalReference::math_sin_double_function(isolate),
           0, 1);
       break;
     case TranscendentalCache::COS:
       __ CallCFunction(ExternalReference::math_cos_double_function(isolate),
           0, 1);
       break;
     case TranscendentalCache::LOG:
@@ skipping 133 matching lines @@
   __ TailCallRuntime(Runtime::kMath_pow_cfunction, 2, 1);
 }
 
 
 bool CEntryStub::NeedsImmovableCode() {
   return true;
 }
 
 
 bool CEntryStub::CompilingCallsToThisStubIsGCSafe() {
-  return !save_doubles_ && result_size_ == 1;
+  return (!save_doubles_ || ISOLATE->fp_stubs_generated()) &&
+          result_size_ == 1;
 }
 
 
 void CodeStub::GenerateStubsAheadOfTime() {
 }
+
+
+void CodeStub::GenerateFPStubs() {
+  CEntryStub save_doubles(1);
+  save_doubles.SaveDoubles();
+  Handle<Code> code = save_doubles.GetCode();
+  code->GetIsolate()->set_fp_stubs_generated(true);
+}
+
+
 void CEntryStub::GenerateThrowTOS(MacroAssembler* masm) {
   __ Throw(r0);
 }
 
 
 void CEntryStub::GenerateThrowUncatchable(MacroAssembler* masm,
                                           UncatchableExceptionType type) {
   __ ThrowUncatchable(type, r0);
 }
 
@@ skipping 3373 matching lines @@
   __ mov(result, Operand::Zero());
   __ Ret();
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM